From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 313D1385802E for ; Wed, 14 Jul 2021 21:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 313D1385802E Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16ELXYXH026595; Wed, 14 Jul 2021 17:51:55 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39ssmrjb1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 17:51:55 -0400 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16ELZQ9l031164; Wed, 14 Jul 2021 17:51:55 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 39ssmrjb1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 17:51:55 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16ELmTSQ032375; Wed, 14 Jul 2021 21:51:54 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma02wdc.us.ibm.com with ESMTP id 39q36cect0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 21:51:54 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16ELprfD33030462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Jul 2021 21:51:53 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 242A36A047; Wed, 14 Jul 2021 21:51:53 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D242D6A04D; Wed, 14 Jul 2021 21:51:52 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.211.124.44]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 14 Jul 2021 21:51:52 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH] Fix regular expression error in PR 100166 patch To: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn , Peter Bergner , Will Schmidt References: <20210714214217.GA12025@ibm-toto.the-meissners.org> From: Bill Schmidt Message-ID: <3055f80e-42fe-e1af-b8e3-77c05dbcfa2b@linux.ibm.com> Date: Wed, 14 Jul 2021 16:51:52 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714214217.GA12025@ibm-toto.the-meissners.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 6mR3OFt9Vyk1FiPT3h-obvkf6CuFD7oq X-Proofpoint-GUID: 7wdkM8zFBORGmhKlTMSNbZR5QOmCBvBh X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-14_11:2021-07-14, 2021-07-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107140130 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 21:51:57 -0000 Hi Mike, On 7/14/21 4:42 PM, Michael Meissner wrote: > Fix regular expression error in PR 100166 patch > > In my patch for PR testsuite/100166 (which fixes various tests so that the > plxv and pstxv instructions can be counted as legitimate instructions), I > had a typo in the pr86731-fwrapv-longlong.c test (using plvx instead of > plxv). This patch fixes this error. > > Can I apply it to the mainline? I have tested this on a big endian power8 > system (using --with-cpu=power8), a little endian power9 system (using > --with-cpu=power9), and on a power10 prototype (using --with-cpu=power10). The > pr86731-fwrapv-longlong.c test passes in all cases. > > 2021-07-14 Michael Meissner > > gcc/testsuite/ > PR testsuite/100166 > * gcc.target/powerpc/pr86731-fwrapv-longlong.c: Fix typo. > --- > gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > index bd1502bb30a..97bc60f7cd6 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr86731-fwrapv-longlong.c > @@ -30,5 +30,5 @@ vector signed long long splats4(void) > > /* { dg-final { scan-assembler-times {\mvspltis[bhw]\M} 0 } } */ > /* { dg-final { scan-assembler-times {\mvsl[bhwd]\M} 0 } } */ > -/* { dg-final { scan-assembler-times {\mp?lxv\M|\mlxv\M|\mlxvd2x\M} 2 } } */ > +/* { dg-final { scan-assembler-times {\mp?lxv?\M|\mlxvd2x\M} 2 } } */ > That doesn't look like what you meant to do... That would accept "lx" among other strings... Thanks, Bill