From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 25683385734B for ; Fri, 21 Apr 2023 19:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25683385734B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1a667067275so22551715ad.1 for ; Fri, 21 Apr 2023 12:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682107099; x=1684699099; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3s5jR2fkSGgbmrB4apzUIeNOntP+y3wBSLdEOldyorw=; b=Uyl2uIOUMy+jbIVZzFkkAXl/9PnuRdiqNn15YxeOZjeijrlSturmBLahCPqe+VfW06 +rOSF6+++04mEDgFeKfGMvooIrXHCJZRavVgsGd6jf9Er/HHCtBrjTcRrLYSvS/RDpt6 l9O8vRygcT506guiR+Ds5xDcY117D5PvAX5Gjs/9vDhUE875wL3YyC+MTHI9s8VzCkzv 5vaj7Npl8PXrWHmByQ7zPKKis+IEyOl5UcOyGxIULBRN3OvEFZcw4g56XuKRl/zWgsKf Yfpx8XMkHV47y/CsoRCplikiv3nobxoYWi7oTDlBi21nBjR7Av2QaYFCz++xQVe7v5ao F7iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682107099; x=1684699099; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3s5jR2fkSGgbmrB4apzUIeNOntP+y3wBSLdEOldyorw=; b=Jdiao6nwYjBj+OdAQA+yMG3eGpdt0nFfqaL+SwNmB6+iEa62QU9UEg37Xd3eVrhxV4 1XFd+v3YibZoWNmwJI+pLo1QeqOsbx0KlGz2diKG72lgFabnWSGpUz85Q+hdAIeJ39/y Z4lOQp7HHoaCObvxG6QZ9FM3d6I5QowVexfbd6Rp2v7tXibc28LamEe9+9UnCjSBo7D9 DhQdoau05Q+hgvieorBU7+ChHdkKLEWlwuMSfLN4XiIztgYknJHv8bSIxYL+j7ciOgjR nlqMohBuA0lUVCElVyAswJhyliVg1HR9xK4YON94oJKxJJi41dXOtv7/IaLBUEU1UDa9 PmrA== X-Gm-Message-State: AAQBX9eIBCS1Zy9ETRk2S4obITAWpzYSGvgiwbXIjqyMoWkCsTWyL2t0 2MwOOuCHDPkZz4HjCmqGtrA= X-Google-Smtp-Source: AKy350YV0JZwHh59U1fEAteL+RjT8oS7Qm5oYNSp20SpOr2j/rjjcTo135rI6s53goLobYXEXctlWA== X-Received: by 2002:a17:902:e881:b0:19f:1871:3dcd with SMTP id w1-20020a170902e88100b0019f18713dcdmr8049490plg.5.1682107098948; Fri, 21 Apr 2023 12:58:18 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id j12-20020a170902690c00b001a6a6169d45sm3067901plk.168.2023.04.21.12.58.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 12:58:18 -0700 (PDT) Message-ID: <308374cd-a73e-e73f-0ea7-fccc55dd9d68@gmail.com> Date: Fri, 21 Apr 2023 13:58:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH v1 10/10] RISC-V: Support XVentanaCondOps extension Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Kito Cheng , Christoph Muellner , Palmer Dabbelt , Andrew Waterman , Vineet Gupta References: <20230210224150.2801962-1-philipp.tomsich@vrull.eu> <20230210224150.2801962-11-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20230210224150.2801962-11-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/10/23 15:41, Philipp Tomsich wrote: > The vendor-defined XVentanaCondOps extension adds two instructions > with semantics identical to Zicond. > > This plugs the 2 new instruction in using the canonical RTX, which > also matches the combiner-input for noce_try_store_flag_mask and > noce_try_store_flag, defined for conditional-zero. > > For documentation on XVentanaCondOps, refer to: > https://github.com/ventanamicro/ventana-custom-extensions/releases/download/v1.0.1/ventana-custom-extensions-v1.0.1.pdf > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_rtx_costs): Recognize idiom > for conditional zero as a single instruction for TARGET_XVENTANACONDOPS. > * config/riscv/riscv.md: Include xventanacondops.md. > * config/riscv/zicond.md: Enable splitters for TARGET_XVENTANACONDOPS. > * config/riscv/xventanacondops.md: New file. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/xventanacondops-and-01.c: New test. > * gcc.target/riscv/xventanacondops-and-02.c: New test. > * gcc.target/riscv/xventanacondops-eq-01.c: New test. > * gcc.target/riscv/xventanacondops-eq-02.c: New test. > * gcc.target/riscv/xventanacondops-ifconv-imm.c: New test. > * gcc.target/riscv/xventanacondops-le-01.c: New test. > * gcc.target/riscv/xventanacondops-le-02.c: New test. > * gcc.target/riscv/xventanacondops-lt-01.c: New test. > * gcc.target/riscv/xventanacondops-lt-03.c: New test. > * gcc.target/riscv/xventanacondops-ne-01.c: New test. > * gcc.target/riscv/xventanacondops-ne-03.c: New test. > * gcc.target/riscv/xventanacondops-ne-04.c: New test. > * gcc.target/riscv/xventanacondops-xor-01.c: New test. OK with the change to use if-then-else. jeff