From: Jeff Law <jeffreyalaw@gmail.com>
To: "juzhe.zhong" <juzhe.zhong@rivai.ai>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"kito.cheng@gmail.com" <kito.cheng@gmail.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>
Subject: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG.
Date: Tue, 27 Dec 2022 17:06:02 -0700 [thread overview]
Message-ID: <30b1c78f-42ab-a634-67bf-7a54b0012a0e@gmail.com> (raw)
In-Reply-To: <91200E8AE78D17FA+15C0DC8B-584B-48FB-B92F-6932C4CCEB51@rivai.ai>
On 12/27/22 16:11, juzhe.zhong wrote:
> You mean only change to this form you suggested in this patch? Since in
> all other places of this PASS,I use RTL_SSA framework to iterate
> instructions and blocks. I use RTL_SSA framework to iterate blocks here
> to make codes look more consistent even though they are same here.
The FOR_EACH_BB is used far more widely than the C++ style found in
RTL-SSA so I'd slightly prefer that style.
jeff
next prev parent reply other threads:[~2022-12-28 0:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 3:08 juzhe.zhong
2022-12-27 21:47 ` Jeff Law
[not found] ` <91200E8AE78D17FA+15C0DC8B-584B-48FB-B92F-6932C4CCEB51@rivai.ai>
2022-12-28 0:06 ` Jeff Law [this message]
2022-12-28 0:24 ` 钟居哲
2022-12-28 1:11 ` Jeff Law
2022-12-28 1:34 ` Kito Cheng
2022-12-28 5:20 ` 钟居哲
2022-12-28 11:47 ` Richard Sandiford
2022-12-28 11:57 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b1c78f-42ab-a634-67bf-7a54b0012a0e@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).