From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 530783858D37 for ; Wed, 28 Dec 2022 00:06:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 530783858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102b.google.com with SMTP id ge16so11017153pjb.5 for ; Tue, 27 Dec 2022 16:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yxA9EUU8kyHnuw126K3D6JqruchM2SbVe40p6+7Gw9c=; b=PXJP+TYKpJ8YvolTB5zO5yXM69M2GEeNAUKDyjQMLENh9oLBJnDcU1rqz2ALaKNylk Qs4na3Cm5jhzRMYvPRGvPFA05QwMDiLAlVU0uOunDTyXL2QImrDhFh3YlJJTZK4SQgK2 aoy5QESI44aFXePHxY0bSYka2Sb58faPiZlOtAiEBxvcTOreBEV1IrHRlJMCtbU3VSyO h0QFvnHM9yTTX9AnVJOxja4klhFtabkJv4XCmOfAoFm8Yqa70xPnVzvhahKHycQiAPIA YHouGQYyI7T5ckmNaI72H46UeqrM8nknUt8Omc230VXdwwZNvpLlrIiY5jDta3NY1oXG bFKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yxA9EUU8kyHnuw126K3D6JqruchM2SbVe40p6+7Gw9c=; b=sz+EDjtB439PsE3wipuSvFEaxgyCW/txk7aOKjoCIZAgfTg3bf4/5thF5LkGUBZDp1 FDFLV3NefhCVYXd3M2e5TeY6wMRBHj6Jp4pklzCd0fVo9hyRGcd2xGiU3f0ju/uOENTI grcZT9RYUVcdR+uHVkmWD5vCyB6eP2Hjmok/ZCYxlrV5ZTKVrhByqr9lUF9bI8vqC0+d Q2BEW5oBnJikTZJYDbK65i3OVSOqiMjqtkPThqazSNYF6/8/zY0ZJ+xcJlq65eazcm0Y mY5KF8cpKZjpNrqwbpAV0w54OR2O/w5guHvAeP90FB/DjIuncpPtW+wzHr1fVhCHVGrq 9Xcw== X-Gm-Message-State: AFqh2kqqoNmKflK5UWqcqc3RQ66pXGDyuqXzBi1p4rmwJwlRPULgrLLu gdltYnGY+8ioJ+7oOQ3pYds= X-Google-Smtp-Source: AMrXdXuCQdF6AiTXyjmoxooVL7lcYQq2OaSLQaDqADFv6UVoRWUoei9aNRljhBNNpyp87NbsgmdLZQ== X-Received: by 2002:a17:902:c3c6:b0:192:8ec7:88cb with SMTP id j6-20020a170902c3c600b001928ec788cbmr3312140plj.12.1672185964176; Tue, 27 Dec 2022 16:06:04 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c24d00b001926ccaa4bcsm6311272plg.161.2022.12.27.16.06.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 16:06:03 -0800 (PST) Message-ID: <30b1c78f-42ab-a634-67bf-7a54b0012a0e@gmail.com> Date: Tue, 27 Dec 2022 17:06:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] RISC-V: Fix ICE of visiting non-existing block in CFG. Content-Language: en-US To: "juzhe.zhong" Cc: "gcc-patches@gcc.gnu.org" , "kito.cheng@gmail.com" , "palmer@dabbelt.com" References: <20221224030800.221397-1-juzhe.zhong@rivai.ai> <91200E8AE78D17FA+15C0DC8B-584B-48FB-B92F-6932C4CCEB51@rivai.ai> From: Jeff Law In-Reply-To: <91200E8AE78D17FA+15C0DC8B-584B-48FB-B92F-6932C4CCEB51@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/27/22 16:11, juzhe.zhong wrote: > You mean only change to this form you suggested in this patch？ Since in > all other places of this PASS，I use RTL_SSA framework to iterate > instructions and blocks. I use RTL_SSA framework to iterate blocks here > to make codes look more consistent even though they are same here. The FOR_EACH_BB is used far more widely than the C++ style found in RTL-SSA so I'd slightly prefer that style. jeff