From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-465928-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 70642 invoked by alias); 3 Nov 2017 23:15:27 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 70587 invoked by uid 89); 3 Nov 2017 23:15:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: sasl.smtp.pobox.com
Received: from pb-smtp1.pobox.com (HELO sasl.smtp.pobox.com) (64.147.108.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 23:15:13 +0000
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])	by pb-smtp1.pobox.com (Postfix) with ESMTP id 3D3A3AAD5A;	Fri,  3 Nov 2017 19:15:08 -0400 (EDT)
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])	by pb-smtp1.pobox.com (Postfix) with ESMTP id 34881AAD59;	Fri,  3 Nov 2017 19:15:08 -0400 (EDT)
Received: from [192.168.1.4] (unknown [76.215.41.237])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 5C1FBAAD57;	Fri,  3 Nov 2017 19:15:07 -0400 (EDT)
Subject: Re: [PATCH 2/2] [i386] PR82002 Part 2: Correct non-immediate offset/invalid INSN
From: Daniel Santos <daniel.santos@pobox.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Rainer Orth <ro@cebitec.uni-bielefeld.de>, Jan Hubicka <hubicka@ucw.cz>, Martin Liska <mliska@suse.cz>, Jakub Jelinek <jakub@redhat.com>
References: <89736618-384e-e6b3-227d-b3b3566d8135@pobox.com> <20171031020932.1092-2-daniel.santos@pobox.com> <CAFULd4ax-SC3AjtTFx_dKbQ+iwjwjemBwrOaMe+q1JYUmiAUvw@mail.gmail.com> <3a120e7e-706e-d16d-9153-344e9d80128c@pobox.com> <CAFULd4ZQceCHVWW+Qhix-M0QeNUv3WcW82-3-T6FtrcOvaKOJA@mail.gmail.com> <1c8c7e62-9a49-8901-be0d-23c3ab3c064b@pobox.com>
Message-ID: <30da6293-6d59-8ccc-135b-7175c178be5f@pobox.com>
Date: Fri, 03 Nov 2017 23:15:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1c8c7e62-9a49-8901-be0d-23c3ab3c064b@pobox.com>
Content-Type: text/plain; charset=utf-8
X-Pobox-Relay-ID: D514E724-C0EC-11E7-BAA6-8EF31968708C-06139138!pb-smtp1.pobox.com
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2017-11/txt/msg00271.txt.bz2

On 11/03/2017 04:22 PM, Daniel Santos wrote:
> ...
> How does this patch look?=C2=A0 (Also, I've updated comments for
> choose_baseaddr.)=C2=A0 Currently re-running tests.
>
> Thanks,
> Daniel
>
> @@ -13110,10 +13125,26 @@ ix86_expand_prologue (void)
>  	 target.  */
>        if (TARGET_SEH)
>  	m->fs.sp_valid =3D false;
> -    }
>=20=20
> -  if (m->call_ms2sysv)
> -    ix86_emit_outlined_ms2sysv_save (frame);
> +      /* If SP offset is non-immediate after allocation of the stack fra=
me,
> +	 then emit SSE saves or stub call prior to allocating the rest of the
> +	 stack frame.  This is less efficient for the out-of-line stub because
> +	 we can't combine allocations across the call barrier, but it's better
> +	 than using a scratch register.  */
> +      else if (!x86_64_immediate_operand (GEN_INT (frame.stack_pointer_o=
ffset - m->fs.sp_realigned_offset), Pmode))

Oops, and also after fixing this formatting...

Daniel