On 24/07/2020 8:27 am, Thomas Schwinge wrote:
> That however completely defeats what we're intending to test here, which
> is to "Test invalid intra-routine parallelism".  The same problem has
> been introduced in og10 commit 6a0b5806b24bfdefe0b0f3ccbcc51299e5195dca
> "Various OpenACC reduction enhancements - test cases" for
> 'gcc/testsuite/c-c++-common/goacc/routine-4.c', which throughout changed:
> 
>      -#pragma acc loop gang reduction (+:red) // { dg-error "disallowed by containing routine" }
>      +#pragma acc loop seq reduction (+:red)
> 
> Please revert that, and instead replace 'reduction (+:red)' with a
> different "dummy loop operation" (just an empty loop body?), and in the
> commit log state that this should've been included in the respective og10
> commit adding the "gang reduction on an orphan loop" checking.
> 

I have reverted all the previous changes and replaced the orphan loop gang 
reductions with empty loops as suggested, and checked that the tests now pass.

Is this version okay for OG10?

Thanks

Kwok