From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85951 invoked by alias); 17 Nov 2016 16:52:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85863 invoked by uid 89); 17 Nov 2016 16:52:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DATE_IN_PAST_24_48,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=self-tests, selftests, transactional, Hx-languages-length:2255 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Nov 2016 16:52:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2944C1FB08 for ; Thu, 17 Nov 2016 16:52:09 +0000 (UTC) Received: from reynosa.quesejoda.com (vpn-54-126.rdu2.redhat.com [10.10.54.126]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAHGq52m006714; Thu, 17 Nov 2016 11:52:06 -0500 Subject: Re: [PR target/78213] Do not ICE on non-empty -fself-test To: Bernd Schmidt , gcc-patches References: <9158b0e8-f6b7-8a71-4d78-6f1b174a8405@redhat.com> <8e94bcf0-a529-476e-23c4-fea00445599b@redhat.com> Cc: David Malcolm , Jakub Jelinek From: Aldy Hernandez Message-ID: <30f92496-eb64-3a75-9cb8-9d1e4d440920@redhat.com> Date: Thu, 17 Nov 2016 16:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8e94bcf0-a529-476e-23c4-fea00445599b@redhat.com> Content-Type: multipart/mixed; boundary="------------C4289AA4B9F5DDDDB2F7D171" X-SW-Source: 2016-11/txt/msg01829.txt.bz2 This is a multi-part message in MIME format. --------------C4289AA4B9F5DDDDB2F7D171 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 812 On 11/14/2016 08:18 AM, Bernd Schmidt wrote: > On 11/11/2016 06:10 PM, Aldy Hernandez wrote: >> The problem in this PR is that -fself-test is being run on a non empty >> source file. This causes init_emit() to run, which sets: >> >> REG_POINTER (virtual_incoming_args_rtx) = 1; >> >> Setting REG_POINTER on the virtual incoming args, causes /f to be >> printed on some RTL dumps, causing the -fself-test machinery to fail at >> matching the expected value. > > How about always running init_emit and testing for the correct output? I would prefer Jakub's suggestion of running in finish_options(). I assume there are other places throughout the self-tests that depend on NOT continuing the compilation process, and I'd hate to plug each one. Would the attached patch be acceptable to both of you? Aldy --------------C4289AA4B9F5DDDDB2F7D171 Content-Type: text/plain; charset=UTF-8; name="curr" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="curr" Content-length: 2168 Y29tbWl0IDUyYjkwNjE2MGExMDliODRhMjZmNWFhMTVhNjUzZjRhZWU2MTI5 NDIKQXV0aG9yOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4K RGF0ZTogICBGcmkgTm92IDExIDA2OjMyOjA4IDIwMTYgLTA4MDAKCiAgICAJ UFIgdGFyZ2V0Lzc4MjEzCiAgICAJKiBvcHRzLmMgKGZpbmlzaF9vcHRpb25z KTogU2V0IC1mc3ludGF4LW9ubHkgaWYgcnVubmluZyBzZWxmCiAgICAJdGVz dHMuCgpkaWZmIC0tZ2l0IGEvZ2NjL29wdHMuYyBiL2djYy9vcHRzLmMKaW5k ZXggZDJkNjEwMC4uY2IyMDE1NCAxMDA2NDQKLS0tIGEvZ2NjL29wdHMuYwor KysgYi9nY2Mvb3B0cy5jCkBAIC03NDQsNiArNzQ0LDE0IEBAIGZpbmlzaF9v cHRpb25zIChzdHJ1Y3QgZ2NjX29wdGlvbnMgKm9wdHMsIHN0cnVjdCBnY2Nf b3B0aW9ucyAqb3B0c19zZXQsCiAgICAgICBvcHRzLT54X2ZsYWdfdG9wbGV2 ZWxfcmVvcmRlciA9IDA7CiAgICAgfQogCisgIC8qIC1mc2VsZi10ZXN0IGRl cGVuZHMgb24gdGhlIHN0YXRlIG9mIHRoZSBjb21waWxlciBwcmlvciB0bwor ICAgICBjb21waWxpbmcgYW55dGhpbmcuICBJZGVhbGx5IGl0IHNob3VsZCBi ZSBydW4gb24gYW4gZW1wdHkgc291cmNlCisgICAgIGZpbGUuICBIb3dldmVy LCBpbiBjYXNlIHdlIGdldCBydW4gd2l0aCBhY3R1YWwgc291cmNlLCBhc3N1 bWUKKyAgICAgLWZzeW50YXgtb25seSB3aGljaCB3aWxsIGluaGliaXQgYW55 IGNvbXBpbGVyIGluaXRpYWxpemF0aW9uCisgICAgIHdoaWNoIG1heSBjb25m dXNlIHRoZSBzZWxmIHRlc3RzLiAgKi8KKyAgaWYgKG9wdHMtPnhfZmxhZ19z ZWxmX3Rlc3QpCisgICAgb3B0cy0+eF9mbGFnX3N5bnRheF9vbmx5ID0gMTsK KwogICBpZiAob3B0cy0+eF9mbGFnX3RtICYmIG9wdHMtPnhfZmxhZ19ub25f Y2FsbF9leGNlcHRpb25zKQogICAgIHNvcnJ5ICgidHJhbnNhY3Rpb25hbCBt ZW1vcnkgaXMgbm90IHN1cHBvcnRlZCB3aXRoIG5vbi1jYWxsIGV4Y2VwdGlv bnMiKTsKIApkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHI3 ODIxMy5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHI3ODIxMy5jCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmU0M2M4M2MKLS0tIC9k ZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjc4MjEzLmMK QEAgLTAsMCArMSwxMSBAQAorLyogeyBkZy1kbyBjb21waWxlIH0gKi8KKy8q IHsgZGctb3B0aW9ucyAiLWZzZWxmLXRlc3QiIH0gKi8KKworLyogVmVyaWZ5 IHRoYXQgLWZzZWxmLXRlc3QgZG9lcyBub3QgZmFpbCBvbiBhIG5vbiBlbXB0 eSBzb3VyY2UuICAqLworCitpbnQgaTsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHZvaWQgYmFyKCk7ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9p ZCBmb28oKQoreworICB3aGlsZSAoaS0tKQorICAgIGJhcigpOworfQorLyog eyBkZy1tZXNzYWdlICJmc2VsZlwtdGVzdDogIiAiLWZzZWxmLXRlc3QiIHsg dGFyZ2V0ICotKi0qIH0gMCB9ICovCg== --------------C4289AA4B9F5DDDDB2F7D171--