From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49459 invoked by alias); 20 Dec 2018 23:35:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 49448 invoked by uid 89); 20 Dec 2018 23:35:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Okay X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Dec 2018 23:35:11 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wBKNShNE058520 for ; Thu, 20 Dec 2018 18:35:10 -0500 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 2pggfq9cpe-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 20 Dec 2018 18:35:09 -0500 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Dec 2018 23:35:09 -0000 Received: from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 20 Dec 2018 23:35:05 -0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wBKNZ43W20316322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 20 Dec 2018 23:35:04 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A60F7C605D; Thu, 20 Dec 2018 23:35:04 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C2ADC6055; Thu, 20 Dec 2018 23:34:54 +0000 (GMT) Received: from ragesh4.local (unknown [9.211.108.112]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 20 Dec 2018 23:34:54 +0000 (GMT) Subject: Re: [PATCH][rs6000] avoid using unaligned vsx or lxvd2x/stxvd2x for memcpy/memmove inline expansion To: Segher Boessenkool Cc: GCC Patches , David Edelsohn , Bill Schmidt References: <0a17416b-57a0-99e7-2e7e-90a63da66fe6@linux.ibm.com> <20181220095119.GP3803@gate.crashing.org> From: Aaron Sawdey Date: Thu, 20 Dec 2018 23:44:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181220095119.GP3803@gate.crashing.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit x-cbid: 18122023-0036-0000-0000-00000A6D737D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010257; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000272; SDB=6.01134681; UDB=6.00589976; IPR=6.00914853; MB=3.00024776; MTD=3.00000008; XFM=3.00000015; UTC=2018-12-20 23:35:07 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18122023-0037-0000-0000-00004A0DD975 Message-Id: <30fd466c-43c7-86aa-81f2-181a9d9ca7fc@linux.ibm.com> X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01519.txt.bz2 On 12/20/18 3:51 AM, Segher Boessenkool wrote: > On Wed, Dec 19, 2018 at 01:53:05PM -0600, Aaron Sawdey wrote: >> Because of POWER9 dd2.1 issues with certain unaligned vsx instructions >> to cache inhibited memory, here is a patch that keeps memmove (and memcpy) >> inline expansion from doing unaligned vector or using vector load/store >> other than lvx/stvx. More description of the issue is here: >> >> https://patchwork.ozlabs.org/patch/814059/ >> >> OK for trunk if bootstrap/regtest ok? > > Okay, but see below. > [snip] > > This is extraordinarily clumsy :-) Maybe something like: > > static rtx > gen_lvx_v4si_move (rtx dest, rtx src) > { > gcc_assert (!(MEM_P (dest) && MEM_P (src)); > gcc_assert (GET_MODE (dest) == V4SImode && GET_MODE (src) == V4SImode); > if (MEM_P (dest)) > return gen_altivec_stvx_v4si_internal (dest, src); > else if (MEM_P (src)) > return gen_altivec_lvx_v4si_internal (dest, src); > else > gcc_unreachable (); > } > > (Or do you allow VOIDmode for src as well?) Anyway, at least get rid of > the useless extra variable. I think this should be better: static rtx gen_lvx_v4si_move (rtx dest, rtx src) { gcc_assert ((MEM_P (dest) && !MEM_P (src)) || (MEM_P (src) && !MEM_P(dest))); gcc_assert (GET_MODE (dest) == V4SImode && GET_MODE (src) == V4SImode); if (MEM_P (dest)) return gen_altivec_stvx_v4si_internal (dest, src); else if (MEM_P (src)) return gen_altivec_lvx_v4si_internal (dest, src); gcc_unreachable (); } I'll commit after I re-regstrap. Thanks! Aaron -- Aaron Sawdey, Ph.D. acsawdey@linux.vnet.ibm.com 050-2/C113 (507) 253-7520 home: 507/263-0782 IBM Linux Technology Center - PPC Toolchain