public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom de Vries <Tom_deVries@mentor.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [testsuite, committed] Reinstate absolute line number in gcc.dg/cpp/19940712-1.c
Date: Wed, 24 May 2017 14:16:00 -0000	[thread overview]
Message-ID: <31337d7a-06d1-cfbe-0bea-ee21dc399a65@mentor.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi,

the line number refers to a line in a header file, so we want to keep 
that absolute.

[ The absolute line numbers that we want to replace are the ones that 
start failing once we add a line at the start of the file.

If an absolute line number refers to a header file, and we add a line at 
the start of the including file, the test won't start to fail. However, 
if we rewrite that line number to a relative one, and add a line at the 
start of the including file, the test will start to fail. ]

Committed.

Thanks,
- Tom


[-- Attachment #2: 0001-Reinstate-absolute-line-number-in-gcc.dg-cpp-19940712-1.c.patch --]
[-- Type: text/x-patch, Size: 810 bytes --]

Reinstate absolute line number in gcc.dg/cpp/19940712-1.c

2017-05-24  Tom de Vries  <tom@codesourcery.com>

	* gcc.dg/cpp/19940712-1.c: Reinstate absolute line number.

---
 gcc/testsuite/gcc.dg/cpp/19940712-1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/cpp/19940712-1.c b/gcc/testsuite/gcc.dg/cpp/19940712-1.c
index 7fd9b15..a79b2f5 100644
--- a/gcc/testsuite/gcc.dg/cpp/19940712-1.c
+++ b/gcc/testsuite/gcc.dg/cpp/19940712-1.c
@@ -2,7 +2,7 @@
 /* PR 4713 */
 
 /* dg.exp doesn't read the header files for magic comments. */
-/* { dg-error "unterminated comment" "" { target *-*-* } .-1 } */
+/* { dg-error "unterminated comment" "" { target *-*-* } 4 } */
 /* { dg-error "unterminated comment" "header error" { target *-*-* } 8 } */
 
 #include "19940712-1.h"

                 reply	other threads:[~2017-05-24 14:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31337d7a-06d1-cfbe-0bea-ee21dc399a65@mentor.com \
    --to=tom_devries@mentor.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).