public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [PING] [PATCH] Fortran: fix bounds check for assignment, class component [PR86100]
Date: Tue, 21 May 2024 20:39:57 +0200	[thread overview]
Message-ID: <3158c15c-ad4f-4b4c-85cf-cee914a27b72@gmx.de> (raw)
In-Reply-To: <trinity-f33b89e5-0a5d-41e6-87a5-db4b49862c5f-1715632038016@3c-app-gmx-bs23>

Am 13.05.24 um 22:27 schrieb Harald Anlauf:
> Dear all,
>
> the attached patch does two things:
>
> - it fixes a bogus array bounds check when deep-copying a class component
>    of a derived type and the class component has rank > 1, the reason being
>    that the previous code compared the full size of one side with the size
>    of the first dimension of the other
>
> - the bounds-check error message that was generated e.g. by an allocate
>    statement with conflicting sizes in the allocation and the source-expr
>    will now use an improved abbreviated name pointing to the component
>    involved, which was introduced in 14-development.
>
> What I could not resolve: a deep copy may still create no useful array
> name in the error message (which I am now unable to trigger).  If someone
> sees how to extract it reliably from the tree, please let me know.
>
> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
>
> I would like to backport this to 14-branch after a decent delay.
>
> Thanks,
> Harald
>


WARNING: multiple messages have this Message-ID
From: Harald Anlauf <anlauf@gmx.de>
To: gcc-patches@gcc.gnu.org
Cc: fortran@gcc.gnu.org
Subject: [PING] [PATCH] Fortran: fix bounds check for assignment, class component [PR86100]
Date: Tue, 21 May 2024 20:39:57 +0200	[thread overview]
Message-ID: <3158c15c-ad4f-4b4c-85cf-cee914a27b72@gmx.de> (raw)
Message-ID: <20240521183957.pwOvsfzSOEsfhaKbooUioz8GRJVBqCuSmQ1YBTy946E@z> (raw)
In-Reply-To: <trinity-f33b89e5-0a5d-41e6-87a5-db4b49862c5f-1715632038016@3c-app-gmx-bs23>

Am 13.05.24 um 22:27 schrieb Harald Anlauf:
> Dear all,
> 
> the attached patch does two things:
> 
> - it fixes a bogus array bounds check when deep-copying a class component
>    of a derived type and the class component has rank > 1, the reason being
>    that the previous code compared the full size of one side with the size
>    of the first dimension of the other
> 
> - the bounds-check error message that was generated e.g. by an allocate
>    statement with conflicting sizes in the allocation and the source-expr
>    will now use an improved abbreviated name pointing to the component
>    involved, which was introduced in 14-development.
> 
> What I could not resolve: a deep copy may still create no useful array
> name in the error message (which I am now unable to trigger).  If someone
> sees how to extract it reliably from the tree, please let me know.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
> 
> I would like to backport this to 14-branch after a decent delay.
> 
> Thanks,
> Harald
> 



  reply	other threads:[~2024-05-21 18:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 20:27 Harald Anlauf
2024-05-21 18:39 ` Harald Anlauf [this message]
2024-05-21 18:39   ` [PING] " Harald Anlauf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3158c15c-ad4f-4b4c-85cf-cee914a27b72@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).