From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Uros Bizjak <ubizjak@gmail.com>,
Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] x86, v2: Define LIBGCC2_UNWIND_ATTRIBUTE on ia32 [PR104781]
Date: Wed, 9 Mar 2022 12:30:51 +0100 (CET) [thread overview]
Message-ID: <3163o35-s98p-r276-p332-8qp566120qq@fhfr.qr> (raw)
In-Reply-To: <Yih6aEjWuKNKsESO@tucnak>
On Wed, 9 Mar 2022, Jakub Jelinek wrote:
> On Wed, Mar 09, 2022 at 08:18:38AM +0100, Richard Biener wrote:
> > I wonder if this is a good case for general-regs-only instead? At
> > least no-sse cannot be functionally equivalent (since then we would
> > not have needed general-regs-only ...).
>
> I think general-regs-only is approx. equivalent to no-mmx,no-sse,
> we don't really need/want mmx in the unwinder I guess.
>
> The following seems to work fine too, regtested with
> -O2 -msse2 -mfpmath=sse -mstackrealign in {C,CXX,XC,TC}FLAGS on i686-linux
> (where without the patch it fails to build).
LGTM.
> 2022-03-09 Jakub Jelinek <jakub@redhat.com>
>
> PR target/104781
> * config/i386/i386.h (LIBGCC2_UNWIND_ATTRIBUTE): Define for ia32.
>
> --- gcc/config/i386/i386.h.jj 2022-02-25 21:59:29.356291326 +0100
> +++ gcc/config/i386/i386.h 2022-03-09 10:00:38.242376504 +0100
> @@ -2848,6 +2848,12 @@ extern enum attr_cpu ix86_schedule;
> #define NUM_X86_64_MS_CLOBBERED_REGS 12
> #endif
>
> +/* __builtin_eh_return can't handle stack realignment, so restrict to
> + general regs in 32-bit libgcc functions that call it. */
> +#ifndef __x86_64__
> +#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("general-regs-only")))
> +#endif
> +
> /*
> Local variables:
> version-control: t
>
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2022-03-09 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 15:06 [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c H.J. Lu
2022-03-08 10:23 ` Jakub Jelinek
2022-03-08 11:15 ` Jakub Jelinek
2022-03-08 12:29 ` Jakub Jelinek
2022-03-08 12:49 ` Eric Botcazou
2022-03-08 15:37 ` H.J. Lu
2022-03-08 15:46 ` Jakub Jelinek
2022-03-08 16:09 ` H.J. Lu
2022-03-08 17:35 ` [PATCH] x86: Define LIBGCC2_UNWIND_ATTRIBUTE on ia32 [PR104781] Jakub Jelinek
2022-03-08 17:49 ` H.J. Lu
2022-03-09 7:18 ` Richard Biener
2022-03-09 9:59 ` [PATCH] x86, v2: " Jakub Jelinek
2022-03-09 11:30 ` Richard Biener [this message]
2022-03-08 17:50 ` [PATCH] x86: " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3163o35-s98p-r276-p332-8qp566120qq@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).