From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 6796D388CE8D for ; Thu, 14 Jul 2022 08:19:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6796D388CE8D Received: by mail-wm1-x331.google.com with SMTP id l68so547545wml.3 for ; Thu, 14 Jul 2022 01:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=WLp6/7wAASRy3juHQpo9SREC1w3tR33ALkwLEcdzQr0=; b=ZMsDQiY09W1/+NISpKMJRBq4F23yDi9xTZNBNI4KPCWrOKXKv6kEl9lId/sUb+Fmh+ bPiIVgcbDA7G8zXDR07yzjjEgYUtwRR/LjqHjkKcq8MIwKlZuL15R+jVxy6gtLSZ/ktl tEmGWKildsrElVHOBgooxk/nS4RENHfSa1SfZsfJOjYBpWzu0p7YXWtNsN3hHcILKHcu pzSeVuIfC0OrOuSib5Sma9a1Py9tRFClSKrzxnwbC7DJEnjMU1hvU4KHVJee4N6e3tJh OLJ9RCmk4ZjpXZ1N1cYfdlxyThbQIzE6IWj570QcyKoi3UgEUOiLFBtT7axETE4LDQM7 nrgQ== X-Gm-Message-State: AJIora88LVZ0KjLMRIH8nIxCbb20FpdO8ubPtdBpEhaSVVSx9VckGY6W YKfg/VEqozKbXTKxS6cKiTDtVWb/Tlrncg== X-Google-Smtp-Source: AGRyM1sBILJqofMSSYUIuayg9uK2mNel+IVSgZs7AIeKCIGj/h6t35w4cjOZmS8humyJB/eSVq2Biw== X-Received: by 2002:a05:600c:4149:b0:3a0:4728:60e7 with SMTP id h9-20020a05600c414900b003a0472860e7mr7685308wmm.10.1657786761066; Thu, 14 Jul 2022 01:19:21 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id g6-20020a056000118600b0021d7050ace4sm818787wrx.77.2022.07.14.01.19.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 01:19:20 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix ICE on view conversion between struct and integer Date: Thu, 14 Jul 2022 10:19:18 +0200 Message-ID: <3179248.aeNJFYEL58@fomalhaut> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart3185344.44csPzL39Z" Content-Transfer-Encoding: 7Bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 08:19:25 -0000 This is a multi-part message in MIME format. --nextPart3185344.44csPzL39Z Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, you can build a view conversion between pretty much anything in Ada including between types with different sizes, although the compiler warns in this case and gigi pads the smaller type to end up with the same size. The attached testcase triggers an ICE at -O or above for one of them: FAIL: gnat.dg/opt98.adb (test for excess errors) Excess errors: during GIMPLE pass: esra +===========================GNAT BUG DETECTED==============================+ | 13.0.0 20220713 (experimental) [master 6f5cf9470aa] (x86_64-suse-linux) GCC error:| | in gimplify_modify_expr, at gimplify.cc:6254 | | Error detected around /home/eric/cvs/gcc/gcc/testsuite/gnat.dg/opt98.adb:10:7| | Compiling /home/eric/cvs/gcc/gcc/testsuite/gnat.dg/opt98.adb | if (gimplify_ctxp->into_ssa && is_gimple_reg (*to_p)) { /* We should have got an SSA name from the start. */ gcc_assert (TREE_CODE (*to_p) == SSA_NAME || ! gimple_in_ssa_p (cfun)); } This happens from prepare_gimple_addressable for the variable to be marked with DECL_NOT_GIMPLE_REG_P when its initialization is gimplified, so it's apparently just a matter of setting the flag earlier. Bootstrapped/regtested on x86-64/Linux, OK for the mainline? 2022-07-14 Eric Botcazou * gimplify.cc (lookup_tmp_var): Add NOT_GIMPLE_REG boolean parameter and set DECL_NOT_GIMPLE_REG_P on the variable according to it. (internal_get_tmp_var): Add NOT_GIMPLE_REG boolean parameter and pass it in the call to lookup_tmp_var. (get_formal_tmp_var): Pass false in the call to lookup_tmp_var. (get_initialized_tmp_var): Likewise. (prepare_gimple_addressable): Call internal_get_tmp_var instead of get_initialized_tmp_var with NOT_GIMPLE_REG set to true. 2022-07-14 Eric Botcazou * gnat.dg/opt98.ads, gnat.dg/opt98.adb: New test. -- Eric Botcazou --nextPart3185344.44csPzL39Z Content-Disposition: attachment; filename="p.diff" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="p.diff" diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc index 04990ad91a6..2ac7ca0855e 100644 --- a/gcc/gimplify.cc +++ b/gcc/gimplify.cc @@ -573,20 +573,26 @@ create_tmp_from_val (tree val) } /* Create a temporary to hold the value of VAL. If IS_FORMAL, try to reuse - an existing expression temporary. */ + an existing expression temporary. If NOT_GIMPLE_REG, mark it as such. */ static tree -lookup_tmp_var (tree val, bool is_formal) +lookup_tmp_var (tree val, bool is_formal, bool not_gimple_reg) { tree ret; + /* We cannot mark a formal temporary with DECL_NOT_GIMPLE_REG_P. */ + gcc_assert (!is_formal || !not_gimple_reg); + /* If not optimizing, never really reuse a temporary. local-alloc won't allocate any variable that is used in more than one basic block, which means it will go into memory, causing much extra work in reload and final and poorer code generation, outweighing the extra memory allocation here. */ if (!optimize || !is_formal || TREE_SIDE_EFFECTS (val)) - ret = create_tmp_from_val (val); + { + ret = create_tmp_from_val (val); + DECL_NOT_GIMPLE_REG_P (ret) = not_gimple_reg; + } else { elt_t elt, *elt_p; @@ -617,7 +623,7 @@ lookup_tmp_var (tree val, bool is_formal) static tree internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p, - bool is_formal, bool allow_ssa) + bool is_formal, bool allow_ssa, bool not_gimple_reg) { tree t, mod; @@ -639,7 +645,7 @@ internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p, } } else - t = lookup_tmp_var (val, is_formal); + t = lookup_tmp_var (val, is_formal, not_gimple_reg); mod = build2 (INIT_EXPR, TREE_TYPE (t), t, unshare_expr (val)); @@ -667,7 +673,7 @@ internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p, tree get_formal_tmp_var (tree val, gimple_seq *pre_p) { - return internal_get_tmp_var (val, pre_p, NULL, true, true); + return internal_get_tmp_var (val, pre_p, NULL, true, true, false); } /* Return a temporary variable initialized with VAL. PRE_P and POST_P @@ -678,7 +684,7 @@ get_initialized_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p /* = NULL */, bool allow_ssa /* = true */) { - return internal_get_tmp_var (val, pre_p, post_p, false, allow_ssa); + return internal_get_tmp_var (val, pre_p, post_p, false, allow_ssa, false); } /* Declare all the variables in VARS in SCOPE. If DEBUG_INFO is true, @@ -4574,13 +4580,10 @@ prepare_gimple_addressable (tree *expr_p, gimple_seq *seq_p) { while (handled_component_p (*expr_p)) expr_p = &TREE_OPERAND (*expr_p, 0); + + /* Do not allow an SSA name as the temporary. */ if (is_gimple_reg (*expr_p)) - { - /* Do not allow an SSA name as the temporary. */ - tree var = get_initialized_tmp_var (*expr_p, seq_p, NULL, false); - DECL_NOT_GIMPLE_REG_P (var) = 1; - *expr_p = var; - } + *expr_p = internal_get_tmp_var (*expr_p, seq_p, NULL, false, false, true); } /* A subroutine of gimplify_modify_expr. Replace a MODIFY_EXPR with --nextPart3185344.44csPzL39Z Content-Disposition: attachment; filename="opt98.ads" Content-Transfer-Encoding: 7Bit Content-Type: text/x-adasrc; charset="UTF-8"; name="opt98.ads" with Ada.Unchecked_Conversion; with System; package Opt98 is type Rec is record I : Integer; end record; function To_Address is new Ada.Unchecked_Conversion (Rec, System.Address); function To_Rec is new Ada.Unchecked_Conversion (System.Address, Rec); A : System.Address with Atomic; function Func return Rec; end Opt98; --nextPart3185344.44csPzL39Z Content-Disposition: attachment; filename="opt98.adb" Content-Transfer-Encoding: 7Bit Content-Type: text/x-adasrc; charset="UTF-8"; name="opt98.adb" -- { dg-do compile } -- { dg-options "-O -gnatws" } package body Opt98 is function Func return Rec is R :Rec; begin A := To_Address ((I => 0)); R := To_Rec (A); return R; end; end Opt98; --nextPart3185344.44csPzL39Z--