From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id AD3873839DD6 for ; Wed, 12 Oct 2022 10:38:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD3873839DD6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x430.google.com with SMTP id bu30so25594817wrb.8 for ; Wed, 12 Oct 2022 03:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubySe6mX1aQhc+BSSINQebGucwtMtvwj27dM6sMSv+o=; b=Bl2AsRA41htgZXLWvgEn2rZkEC1Evwbd6CB+NlC9/ARNnwaP5/X5kqAoPTxq5cnbN9 xaMThnQDmeqN19VMcCKmwN3x67pmiOL6NU/RrmTxYvQFLf6ZdtW2n66iNgV6dk3B875F GkARBDnavG9/ylweNEXCp9Gzo4Z1RbIBVUKgIiK+Y4qmY14Tgi/xOjnDl64Fnb0Y0swU NUPiH/TT3EushXXXt2HGIVNnLov7SZy/T4f+laO7luhxBLu3huHFG0jvkZS/izeUfN5Z YgQSTLUd6jGfXr/wb0ot2CenEC0sMEUSX1vqMplHFO5A8kUcD8F6Fna0jg6u195wxX2T J9kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubySe6mX1aQhc+BSSINQebGucwtMtvwj27dM6sMSv+o=; b=AOhchB4IhUJUeamEQCucsPJVOVqh6s1VmmDLulu9/cW4Pt4IwHE7C+HwoRm59pDbrV 8oGAnWOcEnBvdHaRjpUfkIc54TrziIEsLJXH9JA0CAEJxxzg+6yIz0qrIHRjKJTKBIvC 1sMHdOfw+NJFcaoyawF5TKBfbW73iBfyzqSo3aRZVZnA9pe43QVZ1cYR3cs7RgQjruHA krCRhktBGM883FkZa0p9FOIbERnLXJutxuEonhs1sb7t1BFgDX9aDyIlTHUwy/GOFjPO IhhnbMM1YD+yvY9A6roYfmcijs9lRCSv5YgpHkvrTAwn5qbJpep8cWCPPlzE5WFJ7KDp zXkQ== X-Gm-Message-State: ACrzQf2i46JA8wS3XumIOCkTlYvrjGIzSsIPvQEHym/aL4Jgr/CNm1nt 1Xnt91a4b6YFVDbYqcuLbeHWSg== X-Google-Smtp-Source: AMsMyM5WCzbpeFQ+Tl3Do2SgkfvGBPeOLgbMX7qqPqojMb5Un+LaQ/kAORS9UfIvZlR6eNjsrllDAA== X-Received: by 2002:a5d:6e8e:0:b0:220:5fa1:d508 with SMTP id k14-20020a5d6e8e000000b002205fa1d508mr18783490wrz.337.1665571103390; Wed, 12 Oct 2022 03:38:23 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id o9-20020a05600c510900b003a540fef440sm1624987wms.1.2022.10.12.03.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 03:38:22 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Jakub Jelinek Cc: Jason Merrill , Richard Biener , Jeff Law , Richard Sandiford , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] machmode: Introduce GET_MODE_NEXT_MODE with previous GET_MODE_WIDER_MODE meaning, add new GET_MODE_WIDER_MODE Date: Wed, 12 Oct 2022 12:37:39 +0200 Message-ID: <3193881.aeNJFYEL58@fomalhaut> In-Reply-To: References: <95f2abba-afb4-bb73-a9f0-b1578b28713a@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Though I admit I didn't go carefully through all 24 GET_MODE_WIDER_MODE > uses, 54 FOR_EACH_MODE_IN_CLASS uses, 3 FOR_EACH_MODE uses, 24 > FOR_EACH_MODE_FROM, 6 FOR_EACH_MODE_UNTIL and 15 FOR_EACH_WIDER_MODE uses. > It is more important to go through the GET_MODE_WIDER_MODE and > FOR_EACH_WIDER_MODE uses because the patch changes behavior for those, > the rest keep their previous meaning and so can be changed incrementally > if the other meaning is desirable to them (I've of course changed the 3 > spots I had to change in the previous BFmode patch and whatever triggered > during the bootstraps). > > Thoughts on this? Can't we declare that one is wider than the other, for example BFmode since it has got a larger range? Though I guess this would mean special-casing them in genmodes.cc as they are presumably strictly identical except for the format. -- Eric Botcazou