From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 9FB25383A32B for ; Tue, 7 Jun 2022 20:30:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FB25383A32B Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 257KE8wL017863; Tue, 7 Jun 2022 20:30:48 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gjdheg81t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jun 2022 20:30:47 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 257KUlS1014562; Tue, 7 Jun 2022 20:30:47 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gjdheg81k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jun 2022 20:30:47 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 257KKYof029036; Tue, 7 Jun 2022 20:28:26 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma01dal.us.ibm.com with ESMTP id 3gfy1a48ec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jun 2022 20:28:26 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 257KSOmp28180900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jun 2022 20:28:24 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF798C6059; Tue, 7 Jun 2022 20:28:24 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 199EEC6055; Tue, 7 Jun 2022 20:28:24 +0000 (GMT) Received: from lexx (unknown [9.160.81.62]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 7 Jun 2022 20:28:23 +0000 (GMT) Message-ID: <319dd1f6f5e973d180f5d9d92cef36e61bc084b6.camel@vnet.ibm.com> Subject: Re: [PATCH 3/3] Adjust MMA tests to account for no store vector pair. From: will schmidt To: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , "Kewen.Lin" , David Edelsohn , Peter Bergner Date: Tue, 07 Jun 2022 15:28:23 -0500 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DizZcPt_ebaNPZ5m8U1j5pAcDSP65biT X-Proofpoint-ORIG-GUID: BMmZIxpsGybQj0EdpTAtVSMRJsBCEgLd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-07_09,2022-06-07_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206070084 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 20:30:50 -0000 On Mon, 2022-06-06 at 20:56 -0400, Michael Meissner wrote: > [PATCH 3/3] Adjust MMA tests to account for no store vector pair. > > In changing the default for generating the store vector pair instructions, > I had to adjust several of the MMA tests to remove checking for these > instructions. Mostly I just deleted the scan-assembler lines checking for > stxvp. In two of the tests, I added the -mstore-vector-pair option since > the point of the test was to check for specific cases with store vector > pair instructions. > > I have built bootstrap compilers and run the regression tests on three > different systems: > > 1) Little endian power10 using the --with-cpu=power10 option. > > 2) Little endian power9 using the --with-cpu=power9 option. > > 3) Big endian power8 using the --with-cpu=power8 option. On this system, > both 64-bit and 32-bit code generation was tested. > > There were no regressions in the runs. Can I check this patch into the > trunk? If there are no changes needed for the backports, can I check this > code into the active branches after a burn-in period? > > 2022-06-06 Michael Meissner > > gcc/testsuite/ > > * gcc.target/powerpc/mma-builtin-1.c: Eliminate checking for store > vector pair instructions. > * gcc.target/powerpc/mma-builtin-10-pair.c: Likewise. > * gcc.target/powerpc/mma-builtin-10-quit.c: Likewise. > * gcc.target/powerpc/mma-builtin-2.c: Likewise. > * gcc.target/powerpc/mma-builtin-3.c: Likewise. > * gcc.target/powerpc/mma-builtin-4.c: Likewise. > * gcc.target/powerpc/mma-builtin-5.c: Likewise. > * gcc.target/powerpc/mma-builtin-6.c: Likewise. > * gcc.target/powerpc/mma-builtin-7.c: Likewise. > * gcc.target/powerpc/mma-builtin-9.c: Likewise. > * gcc.target/powerpc/mma-builtin-8.c: Add -mstore-vector-pair. > * gcc.target/powerpc/pr102976.c: Likewise. > --- > gcc/testsuite/gcc.target/powerpc/mma-builtin-1.c | 1 - > gcc/testsuite/gcc.target/powerpc/mma-builtin-10-pair.c | 2 -- > gcc/testsuite/gcc.target/powerpc/mma-builtin-10-quad.c | 2 -- > gcc/testsuite/gcc.target/powerpc/mma-builtin-2.c | 1 - > gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c | 1 - > gcc/testsuite/gcc.target/powerpc/mma-builtin-4.c | 2 -- > gcc/testsuite/gcc.target/powerpc/mma-builtin-5.c | 2 -- > gcc/testsuite/gcc.target/powerpc/mma-builtin-6.c | 1 - > gcc/testsuite/gcc.target/powerpc/mma-builtin-7.c | 2 -- > gcc/testsuite/gcc.target/powerpc/mma-builtin-8.c | 2 +- > gcc/testsuite/gcc.target/powerpc/mma-builtin-9.c | 2 -- > gcc/testsuite/gcc.target/powerpc/pr102976.c | 6 +++++- > 12 files changed, 6 insertions(+), 18 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/powerpc/mma-builtin-1.c b/gcc/testsuite/gcc.target/powerpc/mma-builtin-1.c > index 69ee826e1be..47b45b00403 100644 > --- a/gcc/testsuite/gcc.target/powerpc/mma-builtin-1.c > +++ b/gcc/testsuite/gcc.target/powerpc/mma-builtin-1.c > @@ -260,7 +260,6 @@ foo13b (__vector_quad *dst, __vector_quad *src, vec_t *vec) > > /* { dg-final { scan-assembler-times {\mlxv\M} 40 } } */ > /* { dg-final { scan-assembler-times {\mlxvp\M} 12 } } */ > -/* { dg-final { scan-assembler-times {\mstxvp\M} 40 } } */ > /* { dg-final { scan-assembler-times {\mxxmfacc\M} 20 } } */ > /* { dg-final { scan-assembler-times {\mxxmtacc\M} 6 } } */ > /* { dg-final { scan-assembler-times {\mxvbf16ger2\M} 1 } } */ This all seems straightforward. LGTM, thanks. -Will