From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [arm/testsuite]: Skip pr97969.c if -mthumb is not compatible [PR target/97969]
Date: Tue, 2 Mar 2021 16:25:31 +0000 [thread overview]
Message-ID: <31fddd4e-f979-c8d1-502b-714f60c5bd94@foss.arm.com> (raw)
In-Reply-To: <c63e5e17-af6d-3673-c809-081cabeba576@foss.arm.com>
On 02/03/2021 16:19, Richard Earnshaw via Gcc-patches wrote:
> On 01/03/2021 15:26, Christophe Lyon via Gcc-patches wrote:
>> Ping?
>>
>> On Wed, 3 Feb 2021 at 10:01, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>>>
>>> Ping?
>>> I guess that's obvious enough?
>>>
>>> On Wed, 27 Jan 2021 at 10:03, Christophe Lyon
>>> <christophe.lyon@linaro.org> wrote:
>>>>
>>>> Depending on how the toolchain is configured or how the testsuite is
>>>> executed, -mthumb may not be compatible. Like for other tests, skip
>>>> pr97969.c in this case.
>>>>
>>>> For instance arm-linux-gnueabihf and -march=armv5t in RUNTESTFLAGS.
>>>>
>>>> 2021-01-27 Christophe Lyon <christophe.lyon@linaro.org>
>>>>
>>>> gcc/testsuite/
>>>> PR target/97969
>>>> * gcc.target/arm/pr97969.c: Skip if thumb mode is not available.
>>>>
>>>> diff --git a/gcc/testsuite/gcc.target/arm/pr97969.c
>>>> b/gcc/testsuite/gcc.target/arm/pr97969.c
>>>> index 714a1d1..0b5d07f 100644
>>>> --- a/gcc/testsuite/gcc.target/arm/pr97969.c
>>>> +++ b/gcc/testsuite/gcc.target/arm/pr97969.c
>>>> @@ -1,4 +1,5 @@
>>>> /* { dg-do compile } */
>>>> +/* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */
>>>> /* { dg-options "-std=c99 -fno-omit-frame-pointer -mthumb -w -Os" } */
>>>>
>>>> typedef a[23];
>
> I'm working on a patch to make this sort of change unnecessary (I hope).
> Just running some final checks.
>
> R.
>
Ah, wait. This one already has an explicit -mthumb, so my patch won't
affect this. But why is -mthumb needed for this test anyway? It's just
a compilation test, so why not drop that and we'll generally get better
coverage all round.
R.
next prev parent reply other threads:[~2021-03-02 16:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 9:03 Christophe Lyon
2021-02-03 9:01 ` Christophe Lyon
2021-03-01 15:26 ` Christophe Lyon
2021-03-02 16:19 ` Richard Earnshaw
2021-03-02 16:25 ` Richard Earnshaw [this message]
2021-03-02 18:10 ` Christophe Lyon
2021-03-02 18:14 ` Richard Earnshaw
2021-03-02 18:17 ` Richard Earnshaw
2021-03-02 18:35 ` Christophe Lyon
2021-03-03 14:00 ` Richard Earnshaw
2021-03-15 16:03 ` Christophe Lyon
2021-06-03 8:38 ` Christophe Lyon
2021-06-03 8:39 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31fddd4e-f979-c8d1-502b-714f60c5bd94@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).