From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Support bitmap_copy across representations
Date: Wed, 31 Aug 2022 10:00:45 -0600 [thread overview]
Message-ID: <321ee62b-3256-c01c-7a27-46dcae41039b@gmail.com> (raw)
In-Reply-To: <20220817111127.E7BC13858C83@sourceware.org>
On 8/17/2022 5:11 AM, Richard Biener via Gcc-patches wrote:
> The following started as making the backward threader m_imports
> use the tree representation. Since that interfaces to a list
> representation bitmap in ranger by copying rewriting the tree
> to list to perform the copy is inefficient in that it loses
> balancing. The following adds bitmap_copy_tree_to_list and
> integrates it with the generic bitmap_copy routine. For symmetry
> I also added list to tree copy, relying on auto-balancing, and
> tree to tree copy which I didn't optimize to preserve the
> source balancing but instead use bitmap_copy_tree_to_list and
> have the result auto-balanced again.
>
> I've only exercised the tree to list path and I won't actually
> end up using it but it's at least worth posting.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
>
> Worth pushing?
>
> * bitmap.h: Document set_copy aka bitmap_copy as usable
> for tree representation.
> * bitmap.cc (bitmap_copy_tree_to_list): New helper.
> (bitmap_copy): Support copying all bitmap representation
> combinations.
I'd lean against unless you expect to be using it. But it's not a
strongly held opinion.
jeff
next parent reply other threads:[~2022-08-31 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220817111127.E7BC13858C83@sourceware.org>
2022-08-31 16:00 ` Jeff Law [this message]
2022-08-17 11:11 Richard Biener
-- strict thread matches above, loose matches on Subject: below --
2022-08-17 11:11 Richard Biener
2022-08-17 11:11 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321ee62b-3256-c01c-7a27-46dcae41039b@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).