From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id CA16D384841E for ; Mon, 14 Jun 2021 17:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA16D384841E Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-fTTTcG1QMQugMbRhTX6YxQ-1; Mon, 14 Jun 2021 13:53:51 -0400 X-MC-Unique: fTTTcG1QMQugMbRhTX6YxQ-1 Received: by mail-qk1-f197.google.com with SMTP id c15-20020ae9e20f0000b02903aafa8c83e7so12067926qkc.21 for ; Mon, 14 Jun 2021 10:53:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Oh5Xl1ngmbUddY+eKSBGxF8Xve+/H0Aoe7esAfE7h2k=; b=HterP+WnXQxRuRa8ycvh85nYxps5xFke7SNn8+PC80/toDqEoq5I+NSTlfV1x2ionR FLPvw+hNJfoY8wvoULoP8J4L1W63iHj8CeSfQrvUUB8wjxL4ZAkvBWmDBQLb5iz14Gmh HK/hFDn/TQzTnETGS25dBxAaszEqAZL2J0lZ+pWPV9MHOLovf1y7XhCxuqZhmfXxUFzu zYtJZx8z348/c1zIOqiCSWUBKJ7ZAAAUXbnXZm3rOEnHniOKYqxR31VKZheZ0KfZ7LDu hHPoywhC87FMFgKknq+lzXBLkJO8vGGFVl28qxPuIImRBnHV2p4YWU4yArQGHvA6cKlk 4JCw== X-Gm-Message-State: AOAM533l+uGm3uXLX8+XRz/3X4g/+2dPIJu/BT3hiSkOA4GCRjIg9Zgn AAhhZQf+n8KlOaiJYuiLDa/B45LpNjGiznOXe6WQZIxTmeQfjKzWjxZlpdvmUg0wPSQ2gAqRCUM hfnksFxs+S1MpdXn33Q== X-Received: by 2002:ad4:5fc7:: with SMTP id jq7mr330159qvb.41.1623693230916; Mon, 14 Jun 2021 10:53:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxneDge+syeOCPIHz8mRPipePeC+g8SpCsLvelZvUWmDtoBHWxmmKVWXdP525e+9iGGwkeLLQ== X-Received: by 2002:ad4:5fc7:: with SMTP id jq7mr330149qvb.41.1623693230729; Mon, 14 Jun 2021 10:53:50 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id x9sm10616133qtf.76.2021.06.14.10.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 10:53:50 -0700 (PDT) Message-ID: <3232cfabba68a7d8e71be66f51145eaa253a1a5b.camel@redhat.com> Subject: Re: [PATCH] c-family: Add fix-it suggestions for names [PR101052] From: David Malcolm To: Jonathan Wakely , gcc-patches@gcc.gnu.org Date: Mon, 14 Jun 2021 13:53:49 -0400 In-Reply-To: References: User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 17:53:56 -0000 On Mon, 2021-06-14 at 13:17 +0100, Jonathan Wakely wrote: >         PR c++/101052 > > gcc/c-family/ChangeLog: > >         * known-headers.cc (get_stdlib_header_for_name): Add known >         headers for EXIT_FAILURE, EXIT_SUCCESS, abort, atexit, > calloc, >         exit, and getenv. > > gcc/testsuite/ChangeLog: > >         * g++.dg/spellcheck-stdlib.C: Add checks for names. >         * gcc.dg/spellcheck-stdlib.c: Likewise. > > There are no C tests for the functions because the C front-end > doesn't > give fix-it hints for them, it complains about mismatched implicit > declarations. I assume this is why there were no existing tests for > malloc, free, etc. > > Tested powerpc64le-linux. OK for trunk? > LGTM