From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 8EEB33858C53 for ; Mon, 15 May 2023 10:05:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EEB33858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f41dceb9c9so65999155e9.3 for ; Mon, 15 May 2023 03:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1684145111; x=1686737111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FITK/A7ermmmhTYlDpMBAU0ppVVaUKczUsSxOWJw4tI=; b=MY6+39LcUyTE/j6WQIye2nuPxtVJWhg9023J8aHCUBVqjxw5Uz1bqYMOyNz//i6Gll CqzKZfGKXa+8t5ux7TCX74PIPtGUJVh5UnJr4dn5szEGNf2eV80voo4bbriwE+Se5dyr d+dPdAPWWc1jvgUqx5qC8yNRJ4bPBm0buORBZBFUXp6Uo6Y0yplND0hwsZvsgPs4g/7j HBAXnKPqrL9ETowPatZBr1prx2e+LkiILkw72+ySh2SIpmUwemHEkiRp+vIGdrCJrykT HFAVVgpekBxbglfn+WAvCvKDi1KmQb0ukhKiY9IAwVnlclT9aspYPmlvW4hwj/KUcPHS 01zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684145111; x=1686737111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FITK/A7ermmmhTYlDpMBAU0ppVVaUKczUsSxOWJw4tI=; b=QVDRV2hwcapRz7ftxu7Q7g10QcwMKnSbvqk0w8WT6ifeA6Ob2aBoPTgU0tTbecn6Kl CcmIrMA7NkpkUnkawxh3LYoB2FYS4no/jpmGf++/MqKL6F45Zc90TdPINhH14wJkpUco +bjOeobRa8b8BjNXsg2Nv8FoqE9s5aFj1OjGtKJcH34+CJj5/n84rUO+mfg4Nh3W2rqM VdoPlTJoYxxUQK7oAxeCY6Zcllxc+UgPXv70LKYfIAao4EiDTYG6+CpTJnSRuVMLlRuS 3Xqy8LU7DlQZ3bGRPRUU0fagR5FGmCSGq9B01x16uZ8DS7PJKcAgKmZHl2YMZwRsJ+c4 zDFA== X-Gm-Message-State: AC+VfDxD84g2bB2vwj94stpiqva8gh5AbQDnUAaJYc05lktSYes4J6+T 9KlWdDavQnCatglPCBpvS27dxg== X-Google-Smtp-Source: ACHHUZ6nFDDmqhCTrT6+Rq5ckJXQySLoDormyTUUoMxBedvkd3QdegVX+Glxd+CAaZE0F1QCYpEe2Q== X-Received: by 2002:a5d:410a:0:b0:306:320b:5dbd with SMTP id l10-20020a5d410a000000b00306320b5dbdmr25479267wrp.71.1684145111287; Mon, 15 May 2023 03:05:11 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id e7-20020a5d65c7000000b00307925ff35bsm25101288wrw.49.2023.05.15.03.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 03:05:11 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Bernhard Reutner-Fischer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 01/14] ada: use _P() defines from tree.h Date: Mon, 15 May 2023 12:05:10 +0200 Message-ID: <3235564.44csPzL39Z@fomalhaut> In-Reply-To: <20230513232321.279733-2-rep.dot.nop@gmail.com> References: <20230513232321.279733-1-rep.dot.nop@gmail.com> <20230513232321.279733-2-rep.dot.nop@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > && DECL_RETURN_VALUE_P (inner)) > diff --git a/gcc/ada/gcc-interface/utils.cc b/gcc/ada/gcc-interface/utils.cc > index 0c4f8b90c8e..460ef6f1f01 100644 > --- a/gcc/ada/gcc-interface/utils.cc > +++ b/gcc/ada/gcc-interface/utils.cc > @@ -1966,7 +1966,7 @@ finish_record_type (tree record_type, tree field_list, > int rep_level, bool debug_info_p) > { > const enum tree_code orig_code = TREE_CODE (record_type); > - const bool had_size = TYPE_SIZE (record_type) != NULL_TREE; > + const bool had_size = COMPLETE_TYPE_P (record_type); > const bool had_align = TYPE_ALIGN (record_type) > 0; > /* For all-repped records with a size specified, lay the QUAL_UNION_TYPE > out just like a UNION_TYPE, since the size will be fixed. */ This one is not an improvement but more of a coincidence; the rest is OK. -- Eric Botcazou