From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by sourceware.org (Postfix) with ESMTPS id 08AA23851C39 for ; Wed, 24 Mar 2021 17:14:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 08AA23851C39 Received: by mail-qk1-x732.google.com with SMTP id i9so18759251qka.2 for ; Wed, 24 Mar 2021 10:14:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pVDB35eeRi5lS7bg+9LUgxuWPqf7Cr7KrtcLEyjJcM8=; b=l7+YjvtO4LqLEZFmPCv4oC2yi7pX6ZhHx3nifHG7RW50bGlugoCE3Iya6qtZE9Rqwx PzE+OZfYQHVclMQFa76YpQQwXMHQ52bpXSTGwzebDNJHBAkJWtpfmIBks+sjk54Ql+ko 0SxG8Efp+1DP/npATS6ZQpQq0HaGPUudX8pVq6L5v/yiqgokZbpBpwy7VHo/UqbuJ2YE zGHVxSFkTppUl7YtQexGyxFw+JRacl6PtVVkJQ3JsmQr0cANUWo6g+EMyN+LSBIOBQqN fe8BZXVXSJ9kdt6hFEe7+URVcuSmYIinEnvux12gpq4TZquDNptjN88VAKGJr8ZtOsxV gyew== X-Gm-Message-State: AOAM531QSTu1kPL2l5cD0OyzElcwG/g19bq+QJE5Ij/alyYdQQS+zW2y sjCrbG81E9ke0s8Cha2guNn3YGbS5zo= X-Google-Smtp-Source: ABdhPJwk1j+Ypxn1ACX9QflKsH8wUyIBKTkfPxOCRJmfsh2MqPBNiU4a37h6Pv/GiEGDY03F4PBs+A== X-Received: by 2002:a37:584:: with SMTP id 126mr3955261qkf.274.1616606094457; Wed, 24 Mar 2021 10:14:54 -0700 (PDT) Received: from [192.168.0.41] (71-218-23-248.hlrn.qwest.net. [71.218.23.248]) by smtp.gmail.com with ESMTPSA id g11sm2193389qkk.5.2021.03.24.10.14.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 10:14:54 -0700 (PDT) Subject: Re: Patch ping To: Jakub Jelinek Cc: Jason Merrill , Richard Biener , gcc-patches@gcc.gnu.org References: <20210324114436.GH186063@tucnak> <291474dd-6c23-3d74-1067-4d92b029ed2d@gmail.com> <20210324164052.GJ186063@tucnak> From: Martin Sebor Message-ID: <3269e968-0271-9f0e-9f2b-833cc1988c9a@gmail.com> Date: Wed, 24 Mar 2021 11:14:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210324164052.GJ186063@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 17:14:56 -0000 On 3/24/21 10:40 AM, Jakub Jelinek wrote: > On Wed, Mar 24, 2021 at 09:45:31AM -0600, Martin Sebor via Gcc-patches wrote: >> E.g., OEP_IGNORE_MEMBER_OFFSET or OEP_SAME_MEMBER_OFFSET (for >> the converse of the first) or something like that, but hopefully >> you get the idea. > > Neither of these look like a good name to me, OEP_IGNORE_MEMBER_OFFSET > seems like a request that member offset is not important to the equality, > it is always important, but in the new mode we want not just the member > offset to be equal, but also the fields to be the same, i.e. a stronger > requirement. > > So, what about > /* For OEP_ADDRESS_OF of COMPONENT_REFs, only consider same fields as > equivalent rather than also different fields with the same offset. */ > OEP_ADDRESS_OF_SAME_FIELD = 256 This name works for me. Thanks Martin > > Jakub >