public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@libertysurf.fr>
To: Daniel Cederman <cederman@gaisler.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/2] sparc: Add errata workaround to membar patterns
Date: Mon, 08 Jan 2024 10:32:17 +0100	[thread overview]
Message-ID: <3275405.44csPzL39Z@fomalhaut> (raw)
In-Reply-To: <20240105071913.593978-4-cederman@gaisler.com>

> LEON now uses the standard V8 membar patterns that contains an ldstub
> instruction. This instruction needs to be aligned properly when the
> GR712RC errata workaround is enabled.
> 
> gcc/ChangeLog:
> 
> 	* config/sparc/sparc.cc (atomic_insn_for_leon3_p): Treat 
membar_storeload as atomic
> 	* config/sparc/sync.md: Add GR712RC errata workaround

The second ChangeLog entry should be more detailed:

	* config/sparc/sync.md (membar_storeload): Turn into named insn
	and add GR712RC errata workaround.
	(membar_v8): Add GR712RC errata workaround.

OK with this change.

-- 
Eric Botcazou



  reply	other threads:[~2024-01-08  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05  7:19 [PATCH] sparc: Char arrays are 64-bit aligned on SPARC Daniel Cederman
2024-01-05  7:19 ` [PATCH 1/2] sparc: Revert membar optimization that is not suitable for LEON5 Daniel Cederman
2024-01-08  9:22   ` Eric Botcazou
2024-01-05  7:19 ` [PATCH] sparc: Treat instructions with length 0 as empty Daniel Cederman
2024-01-08  9:26   ` Eric Botcazou
2024-01-05  7:19 ` [PATCH 2/2] sparc: Add errata workaround to membar patterns Daniel Cederman
2024-01-08  9:32   ` Eric Botcazou [this message]
2024-01-08  9:20 ` [PATCH] sparc: Char arrays are 64-bit aligned on SPARC Eric Botcazou
2024-01-08 11:42   ` Daniel Cederman
2024-01-09  8:45     ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3275405.44csPzL39Z@fomalhaut \
    --to=ebotcazou@libertysurf.fr \
    --cc=cederman@gaisler.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).