Re: [PATCH 1/1] aarch64: Sync aarch64-sys-regs.def with Binutils

[Yury Khrustalev <Yury.Khrustalev@arm.com>]

Hi Richard,

> On 20 Mar 2024, at 1:55 PM, Richard Earnshaw (lists) <Richard.Earnshaw@arm.com> wrote:
> 
> On 20/03/2024 11:21, Yury Khrustalev wrote:
>> This patch updates `aarch64-sys-regs.def', bringing it into sync with
>> the Binutils source.
>> 
>> gcc/ChangeLog:
>> 
>>     * config/aarch64/aarch64-sys-regs.def: Copy from Binutils.
> 
> Thanks, I've pushed this.  It's trivial enough and there's value of keeping it in sync with binutils.

Thanks!

> 
> One comment though, there should be one hard tab before "* config/..."; you seem to have some other random characters there that looked like white space.

Thanks for the feedback, I'll make sure to avoid this in the future patches.

> 
> R.
> 
>> ---
>> gcc/config/aarch64/aarch64-sys-regs.def | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/gcc/config/aarch64/aarch64-sys-regs.def b/gcc/config/aarch64/aarch64-sys-regs.def
>> index 6a948171d6e..8b65673a5d6 100644
>> --- a/gcc/config/aarch64/aarch64-sys-regs.def
>> +++ b/gcc/config/aarch64/aarch64-sys-regs.def
>> @@ -521,6 +521,7 @@
>>   SYSREG ("id_aa64isar0_el1", CPENC (3,0,0,6,0), F_REG_READ, AARCH64_NO_FEATURES)
>>   SYSREG ("id_aa64isar1_el1", CPENC (3,0,0,6,1), F_REG_READ, AARCH64_NO_FEATURES)
>>   SYSREG ("id_aa64isar2_el1", CPENC (3,0,0,6,2), F_REG_READ, AARCH64_NO_FEATURES)
>> +  SYSREG ("id_aa64isar3_el1", CPENC (3,0,0,6,3), F_REG_READ, AARCH64_NO_FEATURES)
>>   SYSREG ("id_aa64mmfr0_el1", CPENC (3,0,0,7,0), F_REG_READ, AARCH64_NO_FEATURES)
>>   SYSREG ("id_aa64mmfr1_el1", CPENC (3,0,0,7,1), F_REG_READ, AARCH64_NO_FEATURES)
>>   SYSREG ("id_aa64mmfr2_el1", CPENC (3,0,0,7,2), F_REG_READ, AARCH64_NO_FEATURES)
> 

Kind regards,
Yury