From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-336095-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 31561 invoked by alias); 28 Jan 2013 19:58:06 -0000
Received: (qmail 31553 invoked by uid 22791); 28 Jan 2013 19:58:05 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a45.g.dreamhost.com) (208.113.200.5)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Jan 2013 19:58:00 +0000
Received: from homiemail-a45.g.dreamhost.com (localhost [127.0.0.1])	by homiemail-a45.g.dreamhost.com (Postfix) with ESMTP id C743F480C0;	Mon, 28 Jan 2013 11:57:59 -0800 (PST)
Received: from AMDP6 (81-234-195-35-no56.tbcn.telia.com [81.234.195.35])	(Authenticated sender: rdos@rdos.net)	by homiemail-a45.g.dreamhost.com (Postfix) with ESMTPA id 48795480B6;	Mon, 28 Jan 2013 11:57:58 -0800 (PST)
Message-ID: <329FEE5DE1D3490D85226F0FF93154F2@AMDP6>
From: "Leif Ekblad" <leif@rdos.net>
To: "Uros Bizjak" <ubizjak@gmail.com>
Cc: "Richard Biener" <rguenther@suse.de>,	<gcc-patches@gcc.gnu.org>,	"H.J. Lu" <hjl.tools@gmail.com>,	"Jakub Jelinek" <jakub@redhat.com>
References: <CAFULd4ad2fAQ3YhLVEWmuA8kBnrh6StkHPKWZndv10h3Ecm4GQ@mail.gmail.com>	<4A4D1EB90016420C88D9C8DF7B633E73@AMDP6>	<15368AFB015C4FB9B1FB9B080B43DBE8@AMDP6>	<CAFULd4YgKVK0AHOwdoffs_icDfATiOnFZ541D5jaBJ0ka7ABOQ@mail.gmail.com>	<alpine.LNX.2.00.1301090936130.6889@zhemvz.fhfr.qr>	<E5B069B6BCFF497584F8635FA9BBF98A@AMDP6> <CAFULd4bm8gwLoKkBEEPp8HPepE7X_ikpCeWTq9BrW4XDiRNoJw@mail.gmail.com>
Subject: Re: [PATCH] Adding target rdos to GCC
Date: Mon, 28 Jan 2013 19:58:00 -0000
MIME-Version: 1.0
Content-Type: text/plain;	format=flowed;	charset="iso-8859-1";	reply-type=original
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2013-01/txt/msg01338.txt.bz2

Uros,

That is intentional. The gthr-rdos.h file is part of libgcc. My intention 
was to first patch gcc, then update the patches for newlib, and finally 
libgcc. The gthr-rdos.h file would reference include-files part of newlib, 
so this is kind of circular. I also cannot define the thread model for RDOS 
unless I define this file.

I see a couple of possible solutions:
1. Keep as is. You cannot build libgcc at the current stage anyway, and the 
bootstrap must be built without threading
2. Add an empty gthr-rdos.h file until libgcc is done
3. Remove the threading-model for now, and add it with libgcc instead.

Regards,
Leif Ekblad



----- Original Message ----- 
From: "Uros Bizjak" <ubizjak@gmail.com>
To: "Leif Ekblad" <leif@rdos.net>
Cc: "Richard Biener" <rguenther@suse.de>; <gcc-patches@gcc.gnu.org>; "H.J. 
Lu" <hjl.tools@gmail.com>; "Jakub Jelinek" <jakub@redhat.com>
Sent: Monday, January 28, 2013 8:23 AM
Subject: Re: [PATCH] Adding target rdos to GCC


> On Mon, Jan 28, 2013 at 7:50 AM, Leif Ekblad <leif@rdos.net> wrote:
>
>> If the patch is ok, could some maintainer add it to trunk?
>
> There is no gthr-rdos.h file in your patch:
>
> *** gcc-4.8-20121230/config/gthr.m4 2012-10-15 15:10:30.000000000 +0200
> --- gcc-work/config/gthr.m4 2013-01-07 10:14:04.620667900 +0100
> ***************
> *** 21,26 ****
> --- 21,27 ----
>      tpf) thread_header=config/s390/gthr-tpf.h ;;
>      vxworks) thread_header=config/gthr-vxworks.h ;;
>      win32) thread_header=config/i386/gthr-win32.h ;;
> +     rdos) thread_header=config/i386/gthr-rdos.h ;;
>
> This file should be part of libgcc, so it needs its own ChangeLog.
>
> Uros.