From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Kewen Lin <linkw@gcc.gnu.org>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [testsuite] [ppc] expect vectorization in gen-vect-11c.c
Date: Fri, 7 Apr 2023 17:57:58 +0800 [thread overview]
Message-ID: <329b117c-0a8d-97ff-320d-4e06105d22da@linux.ibm.com> (raw)
In-Reply-To: <orsfdc71fi.fsf@lxoliva.fsfla.org>
Hi Alexandre,
on 2023/4/7 12:37, Alexandre Oliva wrote:
> On Apr 6, 2023, "Kewen.Lin" <linkw@linux.ibm.com> wrote:
>
>> on 2023/4/6 13:20, Alexandre Oliva wrote:
>>> I confirm I observe the problem with gcc-12 targeting ppc64-vx7r2,
>>> containing the backported patch, and that the loop is vectorized,
>>> failing the test.
>
> I take that back. My notes indicate I looked into this failure on March
> 15th. The patch you referenced was dated Feb 10, so I assumed it was
> already in when I looked into it: my confirmation amounted to checking
> what I had observed according to my notes, and when.
>
> But now that you asked me to investigate it again, I used a far more
> recent tree, and I failed to duplicate it. Digging further, I found out
> the patch, despite its commit date, was only merged into gcc-12 on March
> 16th. What I was missing to get the intended effects of the fix was
> just a fresher tree athat actually contained the fix.
aha, good to know it's not due to some differences between our ENVs or
some other mysteries. :) Thanks for checking.
>
> I suppose this means we don't need the testsuite tweak, after all.
Yeah. :)
BR,
Kewen
> Patch withdrawn.
>
prev parent reply other threads:[~2023-04-07 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 8:35 Alexandre Oliva
2023-03-27 7:03 ` Kewen.Lin
2023-04-06 5:20 ` Alexandre Oliva
2023-04-06 6:48 ` Kewen.Lin
2023-04-07 4:37 ` Alexandre Oliva
2023-04-07 9:57 ` Kewen.Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=329b117c-0a8d-97ff-320d-4e06105d22da@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).