From: Jeff Law <law@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Vladimir Makarov <vmakarov@redhat.com>,
Richard Biener <rguenther@suse.de>,
Marc Glisse <marc.glisse@inria.fr>
Subject: Re: [PING**2] [PATCH] Fix asm X constraint (PR inline-asm/59155)
Date: Thu, 04 Aug 2016 20:27:00 -0000 [thread overview]
Message-ID: <32ad9b3d-a0cf-3e8d-4887-fea39ff05d0e@redhat.com> (raw)
In-Reply-To: <AM4PR0701MB216278F8DAAD5C1BDE5672DCE4090@AM4PR0701MB2162.eurprd07.prod.outlook.com>
On 07/21/2016 10:29 AM, Bernd Edlinger wrote:
>>> But I think we have a use case where "X" means really more possible
>>> registers (i.e. includes ss2, mmx etc.) than "g" (only general
>>> registers). Otherwise, in the test cases of pr59155 we would not
>>> have any benefit for using "+X" instead of "+g" or "+r".
>>>
>>> Does that sound reasonable?
>> If it's the case that the real benefit of +X is that it's allowing more
>> registers, then that argues that the backend ought to be providing
>> another (larger) register class.
>>
>
> X allows more different registers than r, and it is already documented.
> In the cases where it is already used, the patch should not break
> anything. I would not understand, why we should forbid the use of X and
> waste another letter of the alphabet for a slightly modified version
> of X.
Doing so essentially allows us to deprecate "X" to used by target
patterns only -- where what's acceptable is limited by the operand
predicates. Those limits ultimately protect the rest of the routines
from having to handle arbitrary RTL.
Meanwhile asms can use the new letter to say "I'll take any register of
any class". Which is, AFAICT, what's desired here.
jeff
next prev parent reply other threads:[~2016-08-04 20:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:45 Bernd Edlinger
2016-06-06 13:33 ` [PING] " Bernd Edlinger
2016-06-06 17:04 ` Vladimir Makarov
2016-06-06 17:54 ` Jeff Law
2016-06-06 18:01 ` Jakub Jelinek
2016-06-06 18:04 ` Jeff Law
2016-06-06 18:09 ` Jakub Jelinek
2016-06-06 19:28 ` Marc Glisse
2016-06-06 19:40 ` Jakub Jelinek
2016-06-09 16:30 ` Jeff Law
2016-06-09 16:43 ` Jakub Jelinek
2016-06-09 16:45 ` Jakub Jelinek
2016-06-10 14:13 ` Bernd Edlinger
2016-06-19 13:25 ` [PING**2] " Bernd Edlinger
2016-06-22 19:51 ` Jeff Law
2016-06-22 20:49 ` Bernd Edlinger
2016-07-20 20:04 ` Jeff Law
2016-07-21 16:30 ` Bernd Edlinger
2016-08-04 20:27 ` Jeff Law [this message]
2016-08-05 13:30 ` Bernd Edlinger
2016-06-20 22:06 ` [PING] " Jeff Law
2016-06-21 1:52 ` Bernd Edlinger
2016-06-07 17:58 ` Bernd Edlinger
2016-06-09 16:28 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ad9b3d-a0cf-3e8d-4887-fea39ff05d0e@redhat.com \
--to=law@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=marc.glisse@inria.fr \
--cc=rguenther@suse.de \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).