From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 7FB0D3858D37 for ; Thu, 27 Apr 2023 16:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FB0D3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="4144963" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 27 Apr 2023 08:38:34 -0800 IronPort-SDR: QDJPfZPRa7YbVbNflFwBvCYoFMcgLJ7/EOyM9FVnWdknb2PBuWaBJ7cw16p3r7oQg8AZora4lt 52Rmq0Aeh6PBkVlf4kikHVU12tEkpa+9elxdhpZ/3kMfnCnvJNBrHSl4cDveXdt3JMGCq/fQRG kwBDxwNtY/9jrJc38GUAs3OID3cC7q/z0WU5/mYjp4+A5hW+1ARPqq1oKgDoGlBQqKoGI6Z14V 1svrWVu/FyxXwWr/fe8MfHGhMZvlF28DqsmQqjNheSrzTw9l0GnqO/2ssC0+aMRHEkaLMeoxWB nfY= Content-Type: multipart/mixed; boundary="------------XvW2bqPBVZTJSBlTltO5Ufql" Message-ID: <32c7f0c6-1a92-5c8a-0607-5aaa1929216a@codesourcery.com> Date: Thu, 27 Apr 2023 17:38:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-GB To: "gcc-patches@gcc.gnu.org" From: Andrew Stubbs Subject: [committed] amdgcn: Fix addsub bug X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------XvW2bqPBVZTJSBlTltO5Ufql Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit I've committed this patch to fix a couple of bugs introduced in the recent CMul patch. First, the fmsubadd insn was accidentally all adds and no substracts. Second, there were input dependencies on the undefined output register which caused the compiler to reserve unnecessary slots in the stack-frame. Both issues are now fixed. This patch is already committed to OG12. I'll backport it to GCC 13 shortly. Andrew --------------XvW2bqPBVZTJSBlTltO5Ufql Content-Type: text/plain; charset="UTF-8"; name="230427-fix-addsub.patch" Content-Disposition: attachment; filename="230427-fix-addsub.patch" Content-Transfer-Encoding: base64 YW1kZ2NuOiBGaXggYWRkc3ViIGJ1ZwoKVGhlIHZlY19mbXN1YmFkZCBpbnN0dWN0aW9uIGFj dHVhbGx5IGhhZCBhZGQgdHdpY2UsIGJ5IG1pc3Rha2UuCgpBbHNvIGltcHJvdmUgY29kZS1n ZW4gZm9yIGFsbCB0aGUgY29tcGxleCBwYXR0ZXJucyBieSB1c2luZyBwcm9wZXJseQp1bmRl ZmluZWQgdmFsdWVzLiAgTW9zdGx5IHRoaXMganVzdCBwcmV2ZW50cyB0aGUgY29tcGlsZXIg cmVzZXJ2aW5nIHNwYWNlCmluIHRoZSBzdGFjayBmcmFtZS4KCmdjYy9DaGFuZ2VMb2c6CgoJ KiBjb25maWcvZ2NuL2djbi12YWx1Lm1kIChjbXVsPGNvbmpfb3A+PG1vZGU+Myk6IFVzZSBn Y25fZ2VuX3VuZGVmLgoJKGNtbDxhZGRzdWJfYXM+PG1vZGU+NCk6IExpa2V3aXNlLgoJKHZl Y19hZGRzdWI8bW9kZT4zKTogTGlrZXdpc2UuCgkoY2FkZDxyb3Q+PG1vZGU+Myk6IExpa2V3 aXNlLgoJKHZlY19mbWFkZHN1Yjxtb2RlPjQpOiBMaWtld2lzZS4KCSh2ZWNfZm1zdWJhZGQ8 bW9kZT40KTogTGlrZXdpc2UsIGFuZCB1c2Ugc3ViIGZvciB0aGUgb2RkIGxhbmVzLgoKZGlm ZiAtLWdpdCBhL2djYy9jb25maWcvZ2NuL2djbi12YWx1Lm1kIGIvZ2NjL2NvbmZpZy9nY24v Z2NuLXZhbHUubWQKaW5kZXggNDRjNDg0NjhkZDYuLjcyOTBjZGMyZmQwIDEwMDY0NAotLS0g YS9nY2MvY29uZmlnL2djbi9nY24tdmFsdS5tZAorKysgYi9nY2MvY29uZmlnL2djbi9nY24t dmFsdS5tZApAQCAtMjMyMyw4ICsyMzIzLDkgQEAgKGRlZmluZV9leHBhbmQgImNtdWw8Y29u al9vcD48bW9kZT4zIgogICAgIHJ0eCBldmVuID0gZ2VuX3J0eF9SRUcgKERJbW9kZSwgRVhF Q19SRUcpOwogICAgIGVtaXRfbW92ZV9pbnNuIChldmVuLCBnZXRfZXhlYyAoMHg1NTU1NTU1 NTU1NTU1NTU1VUwpKTsKICAgICBydHggZGVzdCA9IG9wZXJhbmRzWzBdOwotICAgIGVtaXRf aW5zbiAoZ2VuXzxjbXVsX3N1YmFkZD48bW9kZT4zX2V4ZWMgKGRlc3QsIHQxLCB0MV9wZXJt LCBkZXN0LCBldmVuKSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLy8gYSpjLWIqZCAwCisgICAgZW1pdF9pbnNuIChn ZW5fPGNtdWxfc3ViYWRkPjxtb2RlPjNfZXhlYyAoZGVzdCwgdDEsIHQxX3Blcm0sCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2NuX2dlbl91bmRl ZiAoPE1PREU+bW9kZSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZXZlbikpOyAgICAgICAgICAgIC8vIGEqYy1iKmQgMAogCiAgICAgcnR4IHQy X3Blcm0gPSBnZW5fcmVnX3J0eCAoPE1PREU+bW9kZSk7CiAgICAgZW1pdF9pbnNuIChnZW5f ZHBwX3N3YXBfcGFpcnM8bW9kZT4gKHQyX3Blcm0sIHQyKSk7ICAgICAgICAgIC8vIGIqYyBh KmQKQEAgLTIzNjgsNyArMjM2OSw4IEBAIChkZWZpbmVfZXhwYW5kICJjbWw8YWRkc3ViX2Fz Pjxtb2RlPjQiCiAgICAgcnR4IGV2ZW4gPSBnZW5fcnR4X1JFRyAoREltb2RlLCBFWEVDX1JF Ryk7CiAgICAgZW1pdF9tb3ZlX2luc24gKGV2ZW4sIGdldF9leGVjICgweDU1NTU1NTU1NTU1 NTU1NTVVTCkpOwogICAgIHJ0eCBkZXN0ID0gb3BlcmFuZHNbMF07Ci0gICAgZW1pdF9pbnNu IChnZW5fc3ViPG1vZGU+M19leGVjIChkZXN0LCB0MSwgdDJfcGVybSwgZGVzdCwgZXZlbikp OworICAgIGVtaXRfaW5zbiAoZ2VuX3N1Yjxtb2RlPjNfZXhlYyAoZGVzdCwgdDEsIHQyX3Bl cm0sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnY25fZ2VuX3VuZGVm ICg8TU9ERT5tb2RlKSwgZXZlbikpOwogCiAgICAgcnR4IG9kZCA9IGdlbl9ydHhfUkVHIChE SW1vZGUsIEVYRUNfUkVHKTsKICAgICBlbWl0X21vdmVfaW5zbiAob2RkLCBnZXRfZXhlYyAo MHhhYWFhYWFhYWFhYWFhYWFhVUwpKTsKQEAgLTIzOTIsNyArMjM5NCw4IEBAIChkZWZpbmVf ZXhwYW5kICJ2ZWNfYWRkc3ViPG1vZGU+MyIKICAgICBydHggZGVzdCA9IG9wZXJhbmRzWzBd OwogICAgIHJ0eCB4ID0gb3BlcmFuZHNbMV07CiAgICAgcnR4IHkgPSBvcGVyYW5kc1syXTsK LSAgICBlbWl0X2luc24gKGdlbl9zdWI8bW9kZT4zX2V4ZWMgKGRlc3QsIHgsIHksIGRlc3Qs IGV2ZW4pKTsKKyAgICBlbWl0X2luc24gKGdlbl9zdWI8bW9kZT4zX2V4ZWMgKGRlc3QsIHgs IHksIGdjbl9nZW5fdW5kZWYgKDxNT0RFPm1vZGUpLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZXZlbikpOwogICAgIHJ0eCBvZGQgPSBnZW5fcnR4X1JFRyAoRElt b2RlLCBFWEVDX1JFRyk7CiAgICAgZW1pdF9tb3ZlX2luc24gKG9kZCwgZ2V0X2V4ZWMgKDB4 YWFhYWFhYWFhYWFhYWFhYVVMKSk7CiAgICAgZW1pdF9pbnNuIChnZW5fYWRkPG1vZGU+M19l eGVjIChkZXN0LCB4LCB5LCBkZXN0LCBvZGQpKTsKQEAgLTI0MTksNyArMjQyMiw5IEBAIChk ZWZpbmVfZXhwYW5kICJjYWRkPHJvdD48bW9kZT4zIgogCiAgICAgcnR4IGV2ZW4gPSBnZW5f cnR4X1JFRyAoREltb2RlLCBFWEVDX1JFRyk7CiAgICAgZW1pdF9tb3ZlX2luc24gKGV2ZW4s IGdldF9leGVjICgweDU1NTU1NTU1NTU1NTU1NTVVTCkpOwotICAgIGVtaXRfaW5zbiAoZ2Vu XzxjYWRkX3N1YmFkZD48bW9kZT4zX2V4ZWMgKGRlc3QsIHgsIHksIGRlc3QsIGV2ZW4pKTsK KyAgICBlbWl0X2luc24gKGdlbl88Y2FkZF9zdWJhZGQ+PG1vZGU+M19leGVjIChkZXN0LCB4 LCB5LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdj bl9nZW5fdW5kZWYgKDxNT0RFPm1vZGUpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGV2ZW4pKTsKICAgICBydHggb2RkID0gZ2VuX3J0eF9SRUcg KERJbW9kZSwgRVhFQ19SRUcpOwogICAgIGVtaXRfbW92ZV9pbnNuIChvZGQsIGdldF9leGVj ICgweGFhYWFhYWFhYWFhYWFhYWFVTCkpOwogICAgIGVtaXRfaW5zbiAoZ2VuXzxjYWRkX2Fk ZHN1Yj48bW9kZT4zX2V4ZWMgKGRlc3QsIHgsIHksIGRlc3QsIG9kZCkpOwpAQCAtMjQzOSw3 ICsyNDQ0LDggQEAgKGRlZmluZV9leHBhbmQgInZlY19mbWFkZHN1Yjxtb2RlPjQiCiAgICAg cnR4IGV2ZW4gPSBnZW5fcnR4X1JFRyAoREltb2RlLCBFWEVDX1JFRyk7CiAgICAgZW1pdF9t b3ZlX2luc24gKGV2ZW4sIGdldF9leGVjICgweDU1NTU1NTU1NTU1NTU1NTVVTCkpOwogICAg IHJ0eCBkZXN0ID0gb3BlcmFuZHNbMF07Ci0gICAgZW1pdF9pbnNuIChnZW5fc3ViPG1vZGU+ M19leGVjIChkZXN0LCB0MSwgb3BlcmFuZHNbM10sIGRlc3QsIGV2ZW4pKTsKKyAgICBlbWl0 X2luc24gKGdlbl9zdWI8bW9kZT4zX2V4ZWMgKGRlc3QsIHQxLCBvcGVyYW5kc1szXSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdjbl9nZW5fdW5kZWYgKDxNT0RF Pm1vZGUpLCBldmVuKSk7CiAgICAgcnR4IG9kZCA9IGdlbl9ydHhfUkVHIChESW1vZGUsIEVY RUNfUkVHKTsKICAgICBlbWl0X21vdmVfaW5zbiAob2RkLCBnZXRfZXhlYyAoMHhhYWFhYWFh YWFhYWFhYWFhVUwpKTsKICAgICBlbWl0X2luc24gKGdlbl9hZGQ8bW9kZT4zX2V4ZWMgKGRl c3QsIHQxLCBvcGVyYW5kc1szXSwgZGVzdCwgb2RkKSk7CkBAIC0yNDU5LDEwICsyNDY1LDEx IEBAIChkZWZpbmVfZXhwYW5kICJ2ZWNfZm1zdWJhZGQ8bW9kZT40IgogICAgIHJ0eCBldmVu ID0gZ2VuX3J0eF9SRUcgKERJbW9kZSwgRVhFQ19SRUcpOwogICAgIGVtaXRfbW92ZV9pbnNu IChldmVuLCBnZXRfZXhlYyAoMHg1NTU1NTU1NTU1NTU1NTU1VUwpKTsKICAgICBydHggZGVz dCA9IG9wZXJhbmRzWzBdOwotICAgIGVtaXRfaW5zbiAoZ2VuX2FkZDxtb2RlPjNfZXhlYyAo ZGVzdCwgdDEsIG9wZXJhbmRzWzNdLCBkZXN0LCBldmVuKSk7CisgICAgZW1pdF9pbnNuIChn ZW5fYWRkPG1vZGU+M19leGVjIChkZXN0LCB0MSwgb3BlcmFuZHNbM10sCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBnY25fZ2VuX3VuZGVmICg8TU9ERT5tb2RlKSwg ZXZlbikpOwogICAgIHJ0eCBvZGQgPSBnZW5fcnR4X1JFRyAoREltb2RlLCBFWEVDX1JFRyk7 CiAgICAgZW1pdF9tb3ZlX2luc24gKG9kZCwgZ2V0X2V4ZWMgKDB4YWFhYWFhYWFhYWFhYWFh YVVMKSk7Ci0gICAgZW1pdF9pbnNuIChnZW5fYWRkPG1vZGU+M19leGVjIChkZXN0LCB0MSwg b3BlcmFuZHNbM10sIGRlc3QsIG9kZCkpOworICAgIGVtaXRfaW5zbiAoZ2VuX3N1Yjxtb2Rl PjNfZXhlYyAoZGVzdCwgdDEsIG9wZXJhbmRzWzNdLCBkZXN0LCBvZGQpKTsKIAogICAgIERP TkU7CiAgIH0pCg== --------------XvW2bqPBVZTJSBlTltO5Ufql--