From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 8CCD33857C60 for ; Thu, 28 Oct 2021 13:48:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CCD33857C60 Received: by mail-pj1-x102b.google.com with SMTP id om14so4723996pjb.5 for ; Thu, 28 Oct 2021 06:48:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CQmd+s5vzxDRv1tbK0pbN6gS0E/lljzBB3WwJPB+YIY=; b=4iZfSZHD3SeN6ThZJ6NRbqKMEBBp76yOl+eKJy7nkc1a0ok6fRAW+96luKWv/RJxuz 6bf4xoQQKyVr9gB9+/qYfGWt33lInOxu9+uP4Df4xb1AEwDdNoaRgEgdjgMdGilYUqqX 1MMNyz076dOHClpfMuH1y13BlzT0VZEqGBmL9b77dp+krGlz10gr+5H7//+GDubnbqDH wj+5b6gup/Ws3O8bZTGwrebA67D8XgfiCOpfhwCl1Fz9XD/G3K9oseOkrUjZkS0S4Cy6 VNiCoLQqutUDoWGOJKm4B12N+YYXSHI0dD2VQLdEbRzbeXHffM5VcVeqNdPPZBu8Etvi J8jg== X-Gm-Message-State: AOAM533trPTV5lF8VNdpifViHoLj5MkYNaqUcwIMo7pplwV0ykfV/TJk CLcrYU76NDuJLZT/a6e0r1k77G/4+i0= X-Google-Smtp-Source: ABdhPJzPr896ob61VRCi+VcHMVKno7o727Y4R4kMmLchph6TX0h8KoSyXbm/AgLC7X9RWOExnZ+CSA== X-Received: by 2002:a17:902:b716:b0:13f:b2d1:f316 with SMTP id d22-20020a170902b71600b0013fb2d1f316mr4078188pls.24.1635428920473; Thu, 28 Oct 2021 06:48:40 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id d12sm2416098pfl.141.2021.10.28.06.48.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 06:48:40 -0700 (PDT) Subject: Re: [COMMITTED] Fold all statements in Ranger VRP. To: Andrew MacLeod , gcc-patches References: <8afda780-fe63-5fdd-6d94-e18c8f605bd1@gmail.com> From: Jeff Law Message-ID: <32d4b8a2-a908-0e27-2f01-5efc3b0f4c34@gmail.com> Date: Thu, 28 Oct 2021 07:48:37 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 13:48:43 -0000 On 10/28/2021 7:47 AM, Andrew MacLeod wrote: > On 10/28/21 9:38 AM, Jeff Law wrote: >> >> >> On 10/25/2021 6:03 PM, Andrew MacLeod via Gcc-patches wrote: >>> This patch changes the ranger VRP pass to simplify all statements, >>> not just the ones with ranges.  I believe Jeff had mentioned we were >>> no longer doing this a while back.  Now we need it when running as >>> the VRP2 pass to satisfy the testcase: gcc.dg/wrapped-binop-simplify.c >> I did :-)   The lack of folding in [E]VRP caused a critical function >> in perl to be ever-so-slightly larger and not be inlined leading to a >> measurable performance regression in spec when compiled with gcc-11.  >> I never bothered upstreaming our internal version of this as other >> (non-VRP) changes on the trunk addressed the problem. >> >> Jeff >> > so does this resolve the situation then?  It should, in theory. I would expect so.  It's quite similar to what we're doing internally with our gcc-11 tree. jeff