From: Jeff Law <jeffreyalaw@gmail.com>
To: Patrick O'Neill <patrick@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: palmer@dabbelt.com, gnu-toolchain@rivosinc.com
Subject: Re: [PATCH v2 2/3] RISC-V: Add Zalrsc and Zaamo testsuite support
Date: Wed, 12 Jun 2024 12:14:31 -0600 [thread overview]
Message-ID: <3312c6a8-8f34-43f0-8562-99d64d502305@gmail.com> (raw)
In-Reply-To: <3648a2ea-eed1-42cb-9d36-dd0cb2f8a23d@rivosinc.com>
On 6/11/24 12:21 PM, Patrick O'Neill wrote:
>
> I made the whitespace cleanup patch (trailing whitespace, leading groups
> of 8 spaces -> tabs) for
> target-supports.exp and got a diff of 584 lines.
>
> Is this still worth doing or will it be too disruptive for rebasing/
> other people's development?
I don't think it's overly disruptive. This stuff doesn't have a lot of
churn. It'd be different if you were reformatting the whole tree :-)
Consider those fixes pre-approved.
jeff
next prev parent reply other threads:[~2024-06-12 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 21:53 [PATCH v2 0/3] RISC-V: Add basic Zaamo and Zalrsc support Patrick O'Neill
2024-06-03 21:53 ` [PATCH v2 1/3] " Patrick O'Neill
2024-06-04 3:00 ` Kito Cheng
2024-06-04 17:30 ` Patrick O'Neill
2024-06-04 21:27 ` Andrew Waterman
2024-06-07 22:35 ` Jeff Law
2024-06-03 21:53 ` [PATCH v2 2/3] RISC-V: Add Zalrsc and Zaamo testsuite support Patrick O'Neill
2024-06-07 23:04 ` Jeff Law
2024-06-10 16:39 ` Patrick O'Neill
2024-06-11 18:21 ` Patrick O'Neill
2024-06-12 18:14 ` Jeff Law [this message]
2024-06-03 21:53 ` [PATCH v2 3/3] RISC-V: Add Zalrsc amo-op patterns Patrick O'Neill
2024-06-07 23:11 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3312c6a8-8f34-43f0-8562-99d64d502305@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=palmer@dabbelt.com \
--cc=patrick@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).