From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65868 invoked by alias); 14 Jun 2017 11:20:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64877 invoked by uid 89); 14 Jun 2017 11:20:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw0-f174.google.com Received: from mail-yw0-f174.google.com (HELO mail-yw0-f174.google.com) (209.85.161.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 11:20:46 +0000 Received: by mail-yw0-f174.google.com with SMTP id l75so63184713ywc.3 for ; Wed, 14 Jun 2017 04:20:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=niAdCW5KJQ/yU3l1V/xA4Qj1YT8WxJy/AgZeopKBAqY=; b=N4TBCRclTUCb9oy+rqQ6OkqDyH0MilFI9tYxxYY3wuH8urJEsYwE3NWXwTBdNC/8xg 5cR1O1X+wPi0wv4MXzb+KqYmTe4rWAc02kQjyfWOG0z7uQFJ51a7IoZPlaV704TMIDur P/OQBNi8cFDfAafRCsGWyuobucVn08WTK1S5hCiuID3VIbtie/frWIDzEH39UZMl9s1u dyenvSIHgO9m86hQdNocX3sOrjF6jGHjG4u+Z4GLgjD2xpoRLjSqvM/Soglh5z7fQpZo IA7BULeAX2Atn0PSLhropB3Xwa2qdMRBdH7MrLlYbTTRPdwcV+CpeYetLkTdSJVNRLzA ++ZQ== X-Gm-Message-State: AKS2vOys9tIMEPEg+jznk9qDzMMW9opt7dhkjYpsfg0ILZIz0WzvXPm5 QLODNZReo/ipuQ== X-Received: by 10.129.130.69 with SMTP id s66mr93738ywf.232.1497439249621; Wed, 14 Jun 2017 04:20:49 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:10fb:e5ea:5da2:bbff:4a7c? ([2620:10d:c091:200::2:4b9d]) by smtp.googlemail.com with ESMTPSA id p131sm178223ywe.45.2017.06.14.04.20.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2017 04:20:49 -0700 (PDT) Subject: Re: [C++ PATCH] Cleanup cp_genericize_r To: Jakub Jelinek , Jason Merrill Cc: gcc-patches@gcc.gnu.org References: <20170614060457.GN2099@tucnak> From: Nathan Sidwell Message-ID: <334d15e2-9dc9-4f9e-cd1a-81a8edba2686@acm.org> Date: Wed, 14 Jun 2017 11:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170614060457.GN2099@tucnak> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg01023.txt.bz2 On 06/14/2017 02:04 AM, Jakub Jelinek wrote: > This patch transforms this into a big switch (with 29 case labels), > so that the compiler can decide more easily how to expand it efficiently > (I think we don't have an optimization pass that would transform the above > into a switch). The patch is large, but mostly because I had to reindent > some chunks of code, so I've also attached a diff -upbd which is much > smaller and easier to read. Yes please! > + case FOR_STMT: > + genericize_for_stmt (stmt_p, walk_subtrees, data); > + break; > + case WHILE_STMT: I think it'd read even better with a blank line before cases not preceded by a label statement. You're inconsistent about that. Ok with or without changing that. nathan -- Nathan Sidwell