From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89940 invoked by alias); 9 Dec 2016 15:02:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89925 invoked by uid 89); 9 Dec 2016 15:02:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:584AB9A, H*f:sk:584AB9A, H*MI:sk:584AB9A, H*M:22fb X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Dec 2016 15:02:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 700E97DCEB; Fri, 9 Dec 2016 15:02:49 +0000 (UTC) Received: from localhost.localdomain ([10.36.126.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB9F2m3B028741; Fri, 9 Dec 2016 10:02:48 -0500 Subject: Re: [PATCH] PR78255: Make postreload aware of NO_FUNCTION_CSE To: "Andre Vieira (lists)" , GCC Patches References: <584AB9AA.6030800@arm.com> From: Bernd Schmidt Message-ID: <334ff580-3e7d-22fb-83da-da18acd84244@redhat.com> Date: Fri, 09 Dec 2016 15:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <584AB9AA.6030800@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00865.txt.bz2 On 12/09/2016 03:03 PM, Andre Vieira (lists) wrote: > This patch fixes the issue reported in PR78255 by making postreload > aware it should not be performing CSE on functions if NO_FUNCTION_CSE is > defined to true. > > Bootstrap and full regression on arm-none-linux-gnueabihf and > aarch64-unknown-linux-gnu. > > Also checked this fixed the reported issue on arm-none-eabi. > > Is this OK for trunk? Hmm, it probably doesn't hurt, but looking at the PR I think the originally reported problem suggests you need a different fix: a separate register class to be used for indirect sibling calls. I remember seeing similar issues on other targets. Bernd