From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7FDF93858D1E for ; Tue, 21 May 2024 21:27:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FDF93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FDF93858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716326876; cv=none; b=vWJTvusdIHlpD4o/urlY3equCzvnzrjU96ZWS0yXOSIQzAfv7Erwt+6Y4SjRf03JfLS8raH/x67yOlWTg2YifBdGYLdcQAFLgeoLJ+U0TLm47fiXaM8ve2oH8M02dai8kAon+fYfpUmXfBjJ2clTakL9G5CsThiwycAo4nGxSaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716326876; c=relaxed/simple; bh=WMBomT7WGY3+R5Su5Iiwt5Js52KAcyOvIMkMw79puhk=; h=DKIM-Signature:From:Date:To:Subject:Message-ID:MIME-Version; b=qET3mEBD5drF12iJM8529ZZ4j+OX3Z2nAPaJG5deNtz2+Zt5LkPKH2h6gWFkR3JuM3An/m4C7dv6yt4W1642MYXla3+XpOBpct97d/CmZuvFiPMLTRLcnYYR1Sp4QVENOeqRbq0G4DliT49OQcdd8ur71AjvlsNvBwQveuiOXdQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716326875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yTr7qtNxcYod5tNDbtGSZEkwikNW8RNjLLdlPj1tWBQ=; b=OISUJUpNwEshBHjo5i/MFZC2uvmottDOzMfFuDkJx8pb5Jeuk07yDgGG+EF5AiHj2O8sZz 0Mlm7tbZgm1EXk2z7ILv1dxwdf5ZL1UO3dUZPmYCCUCnvfbu4VqUCUB+v+Srb/d1IPaGvm OefJWYJAlbULO4qeqC3XXXomZtkW+Zg= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-APU0Iug4O7C6gmsNx6bePw-1; Tue, 21 May 2024 17:27:53 -0400 X-MC-Unique: APU0Iug4O7C6gmsNx6bePw-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-3c9a403d9f4so9458439b6e.1 for ; Tue, 21 May 2024 14:27:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716326872; x=1716931672; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yTr7qtNxcYod5tNDbtGSZEkwikNW8RNjLLdlPj1tWBQ=; b=LgXptPgdgSTBtpAXAu7N6GR16keV/SgneVWKvR6asdZv86n+uA69racT2k3gisDZqh avWB5nHVVQvVTvXdOdYF4aivRwFyaNSnQCFUpGIb+pq/FKcC6m9XFjFCvYDTOLximVmo arHaDniK/OTJkONwUkz/qKa9ZGJwbkA9FX+D6O0OgT1XwYJJeffRS6hQxP5CIm1QVPko 57K9Jtv0Mc5Xrptw7QO7obgVxc8LwP/Dk1ZW49XMsSEg0Ghk/cUE4utBYi0GlhNEaW1G NBtfhHJUIPyRuMUAF7Si7O4/OpdNRrKmX2q2MehPbhnbPuiqqgi2F4ti+rz5oylUjsJi NotA== X-Forwarded-Encrypted: i=1; AJvYcCUfvaA8FRATs7jPzDheillyiHeIx8ZUUgJ+6tOwyMG9MwAzK8zbX1KKJGuRdYBFxWex7kbNPJs26VOcFDxD+AFIK782BMaL3w== X-Gm-Message-State: AOJu0YyhCOYJb6HqcWgH9ceytEsGzh0aMaUJl9ZIyq68KYZHU+qs9AfN Uskx0+9R+mmrjXDgy7FHn8bPwdg+ph+K0Nrk/PL66YHSSHQHVh1StKhC8o04WaCsf+PuUvxUDt3 6ykYEIZSPTr1+mhz4qewYyVx/SvllnC1Riah/IPJPCR8MN3H20xxZyAHAopv4uco= X-Received: by 2002:a05:6808:142:b0:3c9:5e47:65a4 with SMTP id 5614622812f47-3cdb3f585c7mr450568b6e.5.1716326871982; Tue, 21 May 2024 14:27:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHC3VXmteNwNdd39LC49Hw+jhOEBfZ0llUjvRuhApdP27S0sLgGMZCtAU0cWP3zVC/H6qll7w== X-Received: by 2002:a05:6808:142:b0:3c9:5e47:65a4 with SMTP id 5614622812f47-3cdb3f585c7mr450543b6e.5.1716326871570; Tue, 21 May 2024 14:27:51 -0700 (PDT) Received: from [192.168.1.130] (ool-18bb2a2e.dyn.optonline.net. [24.187.42.46]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf311570sm1324993285a.100.2024.05.21.14.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 14:27:51 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Tue, 21 May 2024 17:27:50 -0400 (EDT) To: Jason Merrill cc: Patrick Palka , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] c++: canonicity of fn types w/ complex eh specs [PR115159] In-Reply-To: <42726cf3-3bf8-499a-b455-d0181f0b8d3b@redhat.com> Message-ID: <3356d9ff-9c60-a215-427c-9deaf6fb5024@idea> References: <20240521193629.4129787-1-ppalka@redhat.com> <42726cf3-3bf8-499a-b455-d0181f0b8d3b@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 21 May 2024, Jason Merrill wrote: > On 5/21/24 15:36, Patrick Palka wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > > OK for trunk? > > > > Alternatively, I considered fixing this by incrementing > > comparing_specializations around the call to comp_except_specs in > > cp_check_qualified_type, but generally for types whose identity > > depends on whether comparing_specializations is set we need to > > use structural equality anyway IIUC. > > Why not both? I figured the latter change isn't necessary/observable since comparing_specializations would only make a difference for complex exception specifications, and with this patch we won't even call cp_check_qualified_type on a complex eh spec. > > > + bool complex_p = (cr && cr != noexcept_true_spec > > + && !UNPARSED_NOEXCEPT_SPEC_P (cr)); > > Why treat unparsed specs differently from parsed ones? Unparsed specs are unique according to cp_tree_equal, so in turn function types with unparsed specs are unique, so it should be safe to treat such types as canonical. I'm not sure if this optimization matters though; I'm happy to remove this case. > > Jason > >