From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 185893858D35 for ; Mon, 29 Apr 2024 15:20:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 185893858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 185893858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714404039; cv=none; b=HX3NCvqHgm19aC6FniozuLP/agSTbRgftk8NqmgCYFLr/N5XUOj0ZxE6e7yvULs5S1ijuugg+PPJStAu8ykSQUzIaTjQMoOybhWWLvS7qagi2WkiDqc8reCG3L/pZsgPwRzzbD4NXx5KQ6+4OLPaJ16667lqQcTbYmhOr8vK6tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714404039; c=relaxed/simple; bh=fNQZsGZdrrJtEWqaslxd2Xrc2g2FR5Y3bgDp8kG+W24=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=b9d5GkaulI3it2vuKXCQsJ9v2tf6Xfh/libKnqwLLTE5ytNmAtvMsU0xp/jV6hf6xa8TGLH8SOLlTli7/Ym7X6+NjD/xlc9lWXnOpzEJThA1I8HZ4uquvoQEsYMbRMDlR51/wfSCJC4jWFKEvicQmKJVjZd5aFfeP19cWj8Xpyg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6ee0642f718so4190093b3a.0 for ; Mon, 29 Apr 2024 08:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714404036; x=1715008836; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OgPTK4meVcsSm4t7X4WgemLkRAjSCfdk+/ScVtwUEow=; b=YuFci+ZDKQpNpoqwsgNNVX673f3yak5tWle/5rGtxsBM/7Im+Sj2gs13QH9N5sLlv8 vOdVotmAAm8s9yaNTOXmgJRir31hHSWO0gJeCOpm15aYvEMs2QSkH1w5V3xfDQCeag1w jZmDbAYxByYmkEOtNB1aDUzSHJrVI/vaUmFPKv7hZZr+QmO5e4SNlGNaQyyDqFYeudj9 DciBhrL8H03TqkrIJqVli2xa7GGaPC11dnq8dP3X4Eq7C2+uBaHUyDbtTAy+wcYEohT+ e0uo5AkQVGjjEDkfG8T1Ad1I9LbRzjOK70koQuyufuvqWfwA2coTtJhTZD956JWYpSiY 3Oww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714404036; x=1715008836; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OgPTK4meVcsSm4t7X4WgemLkRAjSCfdk+/ScVtwUEow=; b=UjviqRamn7IrQQlCIQFqqkymnsibJweQHtQVQZmWJ3OrebEb61cUNMzbrCJwRvnxmX cV+PyVSQq6e0EMjyHjjoPpndaovTA9yiwx4fuNJjMiX5E9cOlqvmXjOXphrqDRAB/0K3 2mjeYOt9Em7WhvdL0xq63xhHWDtpSmUMMVPBFgX0en9VmLao4xEtuUqi+suf2R1e7CZf 8um8KbW7AwOz3R9vuj4sQmnOpZnOAwpaASd0eqpSbPUvEidQHT2Pr4CPZmPRJnp2hTKR tk2y6IMR6f1uaH3tpb+zEh2ICUquaPRWoxuOLXownnrcA57bA7CmFfZbN9ABMAdfe/mU Va4A== X-Forwarded-Encrypted: i=1; AJvYcCV54KvmIhqB9wY0Aq30ovg53VEVwNkTSaRKCBWCgWS053Q2qgcNQmZhjFmkOL4Tfo2XKoFnn5p159dBg8RHRuSpq53MBSyy/g== X-Gm-Message-State: AOJu0Yz5y898DBy9gTflZpgAEuVsxVVQG0YJebk1ivknng4Qq3BHGMWP dg+LCQAe4A+PKxg8YBdz8eVVqkeY6s+obkO0Lpxb3tHqQT6w4vhJMThasNd4 X-Google-Smtp-Source: AGHT+IHGnK4ARClKByC/neA6dbePBUZtc/qpIXzLZVMQJiMcK7EXFG1Evn2myM8LZAFZsXC7iYqwZg== X-Received: by 2002:a05:6a20:104c:b0:1ad:7cc5:ecee with SMTP id gt12-20020a056a20104c00b001ad7cc5eceemr9371706pzc.5.1714404035700; Mon, 29 Apr 2024 08:20:35 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id dq5-20020a056a020f8500b005dc49afed53sm6573197pgb.55.2024.04.29.08.20.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 08:20:35 -0700 (PDT) Message-ID: <335b7f03-9513-42f2-a1ab-53a15d3145ee@gmail.com> Date: Mon, 29 Apr 2024 09:20:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in get_stored_val Content-Language: en-US To: "Li, Pan2" , Robin Dapp , "gcc-patches@gcc.gnu.org" Cc: "juzhe.zhong@rivai.ai" , "kito.cheng@gmail.com" , "richard.guenther@gmail.com" , "Wang, Yanzhang" , "Liu, Hongtao" References: <20240226032558.587912-1-pan2.li@intel.com> <20240226142235.3215553-1-pan2.li@intel.com> <793c14cb-2a08-41a4-ac55-4c39295f42d3@gmail.com> <2767ff68-98c8-47b6-ac3a-b3f47ba98afa@gmail.com> <2a97fc8b-cb91-46b3-9f72-ec86dbf9ebb1@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/22/24 11:45 PM, Li, Pan2 wrote: > Thanks Jeff for comments. > >> As Richi noted using validate_subreg here isn't great. Does it work to >> factor out this code from extract_low_bits >> >>> if (!int_mode_for_mode (src_mode).exists (&src_int_mode) >>> || !int_mode_for_mode (mode).exists (&int_mode)) >>> return NULL_RTX; >>> >>> if (!targetm.modes_tieable_p (src_int_mode, src_mode)) >>> return NULL_RTX; >>> if (!targetm.modes_tieable_p (int_mode, mode)) >>> return NULL_RTX; > >> And use that in the condition (and in extract_low_bits rather than >> duplicating the code)? > > It can solve the ICE but will forbid all vector modes goes gen_lowpart. > Actually only the vector mode size is less than reg nature size will trigger the ICE. > Thus, how about just add one more condition before goes to gen_lowpart as below? > > Feel free to correct me if any misunderstandings. 😉! > > diff --git a/gcc/dse.cc b/gcc/dse.cc > index edc7a1dfecf..258d2ccc299 100644 > --- a/gcc/dse.cc > +++ b/gcc/dse.cc > @@ -1946,7 +1946,9 @@ get_stored_val (store_info *store_info, machine_mode read_mode, > copy_rtx (store_info->const_rhs)); > else if (VECTOR_MODE_P (read_mode) && VECTOR_MODE_P (store_mode) > && known_le (GET_MODE_BITSIZE (read_mode), GET_MODE_BITSIZE (store_mode)) > - && targetm.modes_tieable_p (read_mode, store_mode)) > + && targetm.modes_tieable_p (read_mode, store_mode) > + /* It's invalid in validate_subreg if read_mode size is < reg natural. */ > + && known_ge (GET_MODE_SIZE (read_mode), REGMODE_NATURAL_SIZE (read_mode))) > read_reg = gen_lowpart (read_mode, copy_rtx (store_info->rhs)); > else > read_reg = extract_low_bits (read_mode, store_mode, So how about this. I'll ack this for the trunk, but not for gcc-14 (at this time). We can revisit for gcc-14 after it's been on the trunk a bit. Realistically that likely means gcc-14.2 at the end of the summer rather than gcc-14.1 which is due in roughly a week. Jeff