* [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
@ 2017-03-15 13:54 Martin Liška
2017-03-15 18:33 ` David Malcolm
0 siblings, 1 reply; 14+ messages in thread
From: Martin Liška @ 2017-03-15 13:54 UTC (permalink / raw)
To: GCC Patches
Hello.
Following small series exclude some strings from pot files via
introduction of internal_error_cont function.
Patch can bootstrap and survives regression tests.
(Sorry for broken threading because my cover letter was rejected).
Martin
marxin (3):
Introduce internal_error_cont function and use it in cfgrtl.c (PR
rtl-optimization/79856).
Replace error with internal_error_cont in cgraph.c (PR ipa/79857).
Regenerate gcc.pot.
gcc/cfgrtl.c | 349 +-
gcc/cgraph.c | 139 +-
gcc/diagnostic-core.h | 1 +
gcc/diagnostic.c | 16 +
gcc/diagnostic.def | 1 +
gcc/po/exgettext | 6 +-
gcc/po/gcc.pot | 14892 ++++++++++++++++++++++++------------------------
7 files changed, 7589 insertions(+), 7815 deletions(-)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-03-15 13:54 [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files Martin Liška
@ 2017-03-15 18:33 ` David Malcolm
2017-03-20 13:10 ` Martin Liška
0 siblings, 1 reply; 14+ messages in thread
From: David Malcolm @ 2017-03-15 18:33 UTC (permalink / raw)
To: Martin Liška, GCC Patches
On Wed, 2017-03-15 at 14:53 +0100, Martin Liška wrote:
> Hello.
>
> Following small series exclude some strings from pot files via
> introduction of internal_error_cont function.
>
> Patch can bootstrap and survives regression tests.
>
> (Sorry for broken threading because my cover letter was rejected).
>
> Martin
>
> marxin (3):
> Introduce internal_error_cont function and use it in cfgrtl.c (PR
> rtl-optimization/79856).
> Replace error with internal_error_cont in cgraph.c (PR ipa/79857).
> Regenerate gcc.pot.
>
> gcc/cfgrtl.c | 349 +-
> gcc/cgraph.c | 139 +-
> gcc/diagnostic-core.h | 1 +
> gcc/diagnostic.c | 16 +
> gcc/diagnostic.def | 1 +
> gcc/po/exgettext | 6 +-
> gcc/po/gcc.pot | 14892 ++++++++++++++++++++++++-------------
> -----------
> 7 files changed, 7589 insertions(+), 7815 deletions(-)
[For some reason I only received the 0/3 and 3/3 mail, not 1/3 and 2/3]
In patch 1:
2017-03-13 Martin Liska <mliska@suse.cz>
PR rtl-optimization/79856
* cfgrtl.c (try_redirect_by_replacing_jump): Fix GNU coding
style.
(fixup_partition_crossing): Likewise.
(fixup_new_cold_bb): Likewise.
(emit_barrier_after_bb): Likewise.
(force_nonfallthru_and_redirect): Likewise.
(last_bb_in_partition): Likewise.
(rtl_split_edge): Likewise.
(commit_one_edge_insertion): Likewise.
(print_rtl_with_bb): Likewise.
(find_partition_fixes): Use internal_error_cont instead of
error.
(verify_hot_cold_block_grouping): Likewise.
(rtl_verify_edges): Likewise.
(rtl_verify_bb_insns): Likewise.
(rtl_verify_bb_pointers): Likewise.
(rtl_verify_bb_insn_chain): Likewise.
(rtl_verify_fallthru): Likewise.
(purge_dead_edges): Fix GNU coding style.
(fixup_abnormal_edges): Likewise.
(fixup_reorder_chain): Likewise.
(duplicate_insn_chain): Likewise.
* diagnostic-core.h (internal_error_cont): Declare new
function.
* diagnostic.c (diagnostic_action_after_output): Handle
newly added DK_INTERNAL_ERROR.
(internal_error_cont): New function.
* diagnostic.def (DK_INTERNAL_ERROR): New enum value.
...the cfgrtl.c changes are a mixture of hunks that are (mostly)
whitespace fixes, combined with hunks that move over to using
internal_error_cont.
Please can you split this patch up to move the cfgrtl.c coding style
fixes into a separate patch, since this obscures the diagnostic
changes?
Also, as Joseph notes, if a function accepts a string param that isn't
to be translated, don't use "gmsgid" or "msgid" as the param name (just
call it "msg" or somesuch).
Thanks
Dave
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-03-15 18:33 ` David Malcolm
@ 2017-03-20 13:10 ` Martin Liška
2017-03-24 9:39 ` Martin Liška
0 siblings, 1 reply; 14+ messages in thread
From: Martin Liška @ 2017-03-20 13:10 UTC (permalink / raw)
To: David Malcolm, GCC Patches; +Cc: Joseph Myers
[-- Attachment #1: Type: text/plain, Size: 2975 bytes --]
On 03/15/2017 07:33 PM, David Malcolm wrote:
> On Wed, 2017-03-15 at 14:53 +0100, Martin Liška wrote:
>> Hello.
>>
>> Following small series exclude some strings from pot files via
>> introduction of internal_error_cont function.
>>
>> Patch can bootstrap and survives regression tests.
>>
>> (Sorry for broken threading because my cover letter was rejected).
>>
>> Martin
>>
>> marxin (3):
>> Introduce internal_error_cont function and use it in cfgrtl.c (PR
>> rtl-optimization/79856).
>> Replace error with internal_error_cont in cgraph.c (PR ipa/79857).
>> Regenerate gcc.pot.
>>
>> gcc/cfgrtl.c | 349 +-
>> gcc/cgraph.c | 139 +-
>> gcc/diagnostic-core.h | 1 +
>> gcc/diagnostic.c | 16 +
>> gcc/diagnostic.def | 1 +
>> gcc/po/exgettext | 6 +-
>> gcc/po/gcc.pot | 14892 ++++++++++++++++++++++++-------------
>> -----------
>> 7 files changed, 7589 insertions(+), 7815 deletions(-)
>
> [For some reason I only received the 0/3 and 3/3 mail, not 1/3 and 2/3]
Hello.
Thanks for notifying me, I'm going to rebase it to just a single patch.
>
> In patch 1:
>
> 2017-03-13 Martin Liska <mliska@suse.cz>
>
> PR rtl-optimization/79856
> * cfgrtl.c (try_redirect_by_replacing_jump): Fix GNU coding
> style.
> (fixup_partition_crossing): Likewise.
> (fixup_new_cold_bb): Likewise.
> (emit_barrier_after_bb): Likewise.
> (force_nonfallthru_and_redirect): Likewise.
> (last_bb_in_partition): Likewise.
> (rtl_split_edge): Likewise.
> (commit_one_edge_insertion): Likewise.
> (print_rtl_with_bb): Likewise.
> (find_partition_fixes): Use internal_error_cont instead of
> error.
> (verify_hot_cold_block_grouping): Likewise.
> (rtl_verify_edges): Likewise.
> (rtl_verify_bb_insns): Likewise.
> (rtl_verify_bb_pointers): Likewise.
> (rtl_verify_bb_insn_chain): Likewise.
> (rtl_verify_fallthru): Likewise.
> (purge_dead_edges): Fix GNU coding style.
> (fixup_abnormal_edges): Likewise.
> (fixup_reorder_chain): Likewise.
> (duplicate_insn_chain): Likewise.
> * diagnostic-core.h (internal_error_cont): Declare new
> function.
> * diagnostic.c (diagnostic_action_after_output): Handle
> newly added DK_INTERNAL_ERROR.
> (internal_error_cont): New function.
> * diagnostic.def (DK_INTERNAL_ERROR): New enum value.
>
> ...the cfgrtl.c changes are a mixture of hunks that are (mostly)
> whitespace fixes, combined with hunks that move over to using
> internal_error_cont.
>
> Please can you split this patch up to move the cfgrtl.c coding style
> fixes into a separate patch, since this obscures the diagnostic
> changes?
Agree, I'll leave formatting stuff to next stage1.
>
> Also, as Joseph notes, if a function accepts a string param that isn't
> to be translated, don't use "gmsgid" or "msgid" as the param name (just
> call it "msg" or somesuch).
I see, please look at second version of patch I've been currently testing.
Martin
>
> Thanks
> Dave
>
[-- Attachment #2: 0001-Introduce-internal_error_cont-function-and-use-it.patch.bz2 --]
[-- Type: application/x-bzip, Size: 127110 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-03-20 13:10 ` Martin Liška
@ 2017-03-24 9:39 ` Martin Liška
2017-03-24 16:22 ` Martin Sebor
2017-04-06 16:44 ` Jeff Law
0 siblings, 2 replies; 14+ messages in thread
From: Martin Liška @ 2017-03-24 9:39 UTC (permalink / raw)
To: David Malcolm, GCC Patches; +Cc: Joseph Myers, Martin Sebor
I would like to ping that. I'm not sure what's agreement after I read
discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
Martin Sebor may know, CC'ing him.
Thanks,
Martin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-03-24 9:39 ` Martin Liška
@ 2017-03-24 16:22 ` Martin Sebor
2017-03-24 17:51 ` Jeff Law
2017-04-06 16:44 ` Jeff Law
1 sibling, 1 reply; 14+ messages in thread
From: Martin Sebor @ 2017-03-24 16:22 UTC (permalink / raw)
To: Martin Liška, David Malcolm, GCC Patches; +Cc: Joseph Myers
On 03/24/2017 03:29 AM, Martin Liška wrote:
> I would like to ping that. I'm not sure what's agreement after I read
> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>
> Martin Sebor may know, CC'ing him.
I haven't seen any followup posts after the one above. The other
(and I think more important point, one with a bearing on the whole
patch series) to consider is the one made by translator Frederic
Marchal in comment #2 in bug 80055.
Martin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-03-24 16:22 ` Martin Sebor
@ 2017-03-24 17:51 ` Jeff Law
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Law @ 2017-03-24 17:51 UTC (permalink / raw)
To: Martin Sebor, Martin Liška, David Malcolm, GCC Patches; +Cc: Joseph Myers
On 03/24/2017 09:37 AM, Martin Sebor wrote:
> On 03/24/2017 03:29 AM, Martin Liška wrote:
>> I would like to ping that. I'm not sure what's agreement after I read
>> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>>
>> Martin Sebor may know, CC'ing him.
>
> I haven't seen any followup posts after the one above. The other
> (and I think more important point, one with a bearing on the whole
> patch series) to consider is the one made by translator Frederic
> Marchal in comment #2 in bug 80055.
It's on the list of things to evaluate. The non-gcc stuff on my plate
is just about wrapped up, at which point I can give more attention to
gcc stuff.
Jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-03-24 9:39 ` Martin Liška
2017-03-24 16:22 ` Martin Sebor
@ 2017-04-06 16:44 ` Jeff Law
2017-04-06 20:58 ` [wwwdocs, PATCH v2] C++ terminology: the One Definition Rule in diagnostics David Malcolm
2017-04-07 10:30 ` [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files Martin Liška
1 sibling, 2 replies; 14+ messages in thread
From: Jeff Law @ 2017-04-06 16:44 UTC (permalink / raw)
To: Martin Liška, David Malcolm, GCC Patches; +Cc: Joseph Myers, Martin Sebor
On 03/24/2017 03:29 AM, Martin Liška wrote:
> I would like to ping that. I'm not sure what's agreement after I read
> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>
> Martin Sebor may know, CC'ing him.
Not sure if you're pinging the internal_error_cont stuff, or the ODR
diagnostics changes.
WRT the ODR diagnostics, I'd say let's go with the C++17 style
(all-lowercase with a hyphen).
If you've got a pointer to the internal_err_cont changes, please pass it
along.
jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* [wwwdocs, PATCH v2] C++ terminology: the One Definition Rule in diagnostics
2017-04-06 16:44 ` Jeff Law
@ 2017-04-06 20:58 ` David Malcolm
2017-04-10 7:38 ` Gerald Pfeifer
2017-04-07 10:30 ` [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files Martin Liška
1 sibling, 1 reply; 14+ messages in thread
From: David Malcolm @ 2017-04-06 20:58 UTC (permalink / raw)
To: Jeff Law, Martin Liška, GCC Patches; +Cc: Joseph Myers, Martin Sebor
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On Thu, 2017-04-06 at 10:44 -0600, Jeff Law wrote:
> On 03/24/2017 03:29 AM, Martin Liška wrote:
> > I would like to ping that. I'm not sure what's agreement after I
> > read
> > discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
> >
> > Martin Sebor may know, CC'ing him.
> Not sure if you're pinging the internal_error_cont stuff, or the ODR
> diagnostics changes.
>
> WRT the ODR diagnostics, I'd say let's go with the C++17 style
> (all-lowercase with a hyphen).
Here's an updated version of the patch for the coding conventions page
of the website, which makes that recommendation (with a leading "the").
For easy of review, the pertinent table headings are:
<th>Use...</th><th>...instead of</th><th>Rationale</th>
OK to commit?
(I've got a followup patch to update the diagnostics accordingly)
> If you've got a pointer to the internal_err_cont changes, please pass
> it
> along.
>
> jeff
>
[-- Attachment #2: odr.patch --]
[-- Type: text/x-patch, Size: 752 bytes --]
Index: htdocs/codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.80
diff -u -p -r1.80 codingconventions.html
--- htdocs/codingconventions.html 13 Mar 2017 22:01:05 -0000 1.80
+++ htdocs/codingconventions.html 6 Apr 2017 20:55:51 -0000
@@ -448,6 +448,12 @@ and code. The following table lists som
<td>"Objective C"</td>
</tr>
<tr>
+ <td>"the one-definition rule"</td>
+ <td>"One Definition Rule", "the C++ One Definition Rule",
+ or "one definition rule"</td>
+ <td>Style used in the C++17 standard</td>
+ </tr>
+ <tr>
<td>"prologue"</td>
<td>"prolog"</td>
<td>Established convention</td>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-04-06 16:44 ` Jeff Law
2017-04-06 20:58 ` [wwwdocs, PATCH v2] C++ terminology: the One Definition Rule in diagnostics David Malcolm
@ 2017-04-07 10:30 ` Martin Liška
2017-04-10 15:42 ` Jeff Law
1 sibling, 1 reply; 14+ messages in thread
From: Martin Liška @ 2017-04-07 10:30 UTC (permalink / raw)
To: Jeff Law, David Malcolm, GCC Patches; +Cc: Joseph Myers, Martin Sebor
On 04/06/2017 06:44 PM, Jeff Law wrote:
> On 03/24/2017 03:29 AM, Martin Liška wrote:
>> I would like to ping that. I'm not sure what's agreement after I read
>> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>>
>> Martin Sebor may know, CC'ing him.
> Not sure if you're pinging the internal_error_cont stuff, or the ODR diagnostics changes.
>
> WRT the ODR diagnostics, I'd say let's go with the C++17 style (all-lowercase with a hyphen).
>
> If you've got a pointer to the internal_err_cont changes, please pass it along.
Yep, I was interested in internal_err_cont. It's next stage1 material, but I'm willing to have
a feedback whether separation of internal messages is desired to be excluded from translation or not?
Martin
>
> jeff
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [wwwdocs, PATCH v2] C++ terminology: the One Definition Rule in diagnostics
2017-04-06 20:58 ` [wwwdocs, PATCH v2] C++ terminology: the One Definition Rule in diagnostics David Malcolm
@ 2017-04-10 7:38 ` Gerald Pfeifer
0 siblings, 0 replies; 14+ messages in thread
From: Gerald Pfeifer @ 2017-04-10 7:38 UTC (permalink / raw)
To: David Malcolm
Cc: Jeff Law, Martin Liška, GCC Patches, Joseph Myers, Martin Sebor
On Thu, 6 Apr 2017, David Malcolm wrote:
> OK to commit?
If that's what the standard uses, yes, thanks. (We still may
want to add "C++" in there, unless you feel the context is always
clear enough anyway, which I could well see...)
Gerald
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-04-07 10:30 ` [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files Martin Liška
@ 2017-04-10 15:42 ` Jeff Law
2017-04-10 15:44 ` Richard Biener
0 siblings, 1 reply; 14+ messages in thread
From: Jeff Law @ 2017-04-10 15:42 UTC (permalink / raw)
To: Martin Liška, David Malcolm, GCC Patches; +Cc: Joseph Myers, Martin Sebor
On 04/07/2017 04:30 AM, Martin Liška wrote:
> On 04/06/2017 06:44 PM, Jeff Law wrote:
>> On 03/24/2017 03:29 AM, Martin Liška wrote:
>>> I would like to ping that. I'm not sure what's agreement after I read
>>> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>>>
>>> Martin Sebor may know, CC'ing him.
>> Not sure if you're pinging the internal_error_cont stuff, or the ODR diagnostics changes.
>>
>> WRT the ODR diagnostics, I'd say let's go with the C++17 style (all-lowercase with a hyphen).
>>
>> If you've got a pointer to the internal_err_cont changes, please pass it along.
>
> Yep, I was interested in internal_err_cont. It's next stage1 material, but I'm willing to have
> a feedback whether separation of internal messages is desired to be excluded from translation or not?
As stage1 stuff, I'll largely be ignoring.
I'm torn on translating this stuff. It's hard enough for a
non-developer to interpret an ICE message, if it's not in their native
language it'd be impossible.
OTOH, if we translate and the user forwards the translated message to
us, we may not be able to interpret.
That probably argues there's some part that should be translated to be
easier for the users, but the real guts of the message should not be
translated.
jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-04-10 15:42 ` Jeff Law
@ 2017-04-10 15:44 ` Richard Biener
2017-06-30 10:31 ` Martin Liška
0 siblings, 1 reply; 14+ messages in thread
From: Richard Biener @ 2017-04-10 15:44 UTC (permalink / raw)
To: Jeff Law
Cc: Martin Liška, David Malcolm, GCC Patches, Joseph Myers,
Martin Sebor
On Mon, Apr 10, 2017 at 5:42 PM, Jeff Law <law@redhat.com> wrote:
> On 04/07/2017 04:30 AM, Martin Liška wrote:
>>
>> On 04/06/2017 06:44 PM, Jeff Law wrote:
>>>
>>> On 03/24/2017 03:29 AM, Martin Liška wrote:
>>>>
>>>> I would like to ping that. I'm not sure what's agreement after I read
>>>> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>>>>
>>>> Martin Sebor may know, CC'ing him.
>>>
>>> Not sure if you're pinging the internal_error_cont stuff, or the ODR
>>> diagnostics changes.
>>>
>>> WRT the ODR diagnostics, I'd say let's go with the C++17 style
>>> (all-lowercase with a hyphen).
>>>
>>> If you've got a pointer to the internal_err_cont changes, please pass it
>>> along.
>>
>>
>> Yep, I was interested in internal_err_cont. It's next stage1 material, but
>> I'm willing to have
>> a feedback whether separation of internal messages is desired to be
>> excluded from translation or not?
>
> As stage1 stuff, I'll largely be ignoring.
>
> I'm torn on translating this stuff. It's hard enough for a non-developer to
> interpret an ICE message, if it's not in their native language it'd be
> impossible.
>
> OTOH, if we translate and the user forwards the translated message to us, we
> may not be able to interpret.
>
> That probably argues there's some part that should be translated to be
> easier for the users, but the real guts of the message should not be
> translated.
Message number and catalogue.
/me runs...
> jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-04-10 15:44 ` Richard Biener
@ 2017-06-30 10:31 ` Martin Liška
2017-06-30 15:11 ` Jeff Law
0 siblings, 1 reply; 14+ messages in thread
From: Martin Liška @ 2017-06-30 10:31 UTC (permalink / raw)
To: Richard Biener, Jeff Law
Cc: David Malcolm, GCC Patches, Joseph Myers, Martin Sebor
On 04/10/2017 05:44 PM, Richard Biener wrote:
> On Mon, Apr 10, 2017 at 5:42 PM, Jeff Law <law@redhat.com> wrote:
>> On 04/07/2017 04:30 AM, Martin Liška wrote:
>>>
>>> On 04/06/2017 06:44 PM, Jeff Law wrote:
>>>>
>>>> On 03/24/2017 03:29 AM, Martin Liška wrote:
>>>>>
>>>>> I would like to ping that. I'm not sure what's agreement after I read
>>>>> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>>>>>
>>>>> Martin Sebor may know, CC'ing him.
>>>>
>>>> Not sure if you're pinging the internal_error_cont stuff, or the ODR
>>>> diagnostics changes.
>>>>
>>>> WRT the ODR diagnostics, I'd say let's go with the C++17 style
>>>> (all-lowercase with a hyphen).
>>>>
>>>> If you've got a pointer to the internal_err_cont changes, please pass it
>>>> along.
>>>
>>>
>>> Yep, I was interested in internal_err_cont. It's next stage1 material, but
>>> I'm willing to have
>>> a feedback whether separation of internal messages is desired to be
>>> excluded from translation or not?
>>
>> As stage1 stuff, I'll largely be ignoring.
>>
>> I'm torn on translating this stuff. It's hard enough for a non-developer to
>> interpret an ICE message, if it's not in their native language it'd be
>> impossible.
>>
>> OTOH, if we translate and the user forwards the translated message to us, we
>> may not be able to interpret.
>>
>> That probably argues there's some part that should be translated to be
>> easier for the users, but the real guts of the message should not be
>> translated.
>
> Message number and catalogue.
>
> /me runs...
>
>> jeff
I there any discussion going on this topic? If not, I'll probably leave it as it is.
Thanks,
Martin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files
2017-06-30 10:31 ` Martin Liška
@ 2017-06-30 15:11 ` Jeff Law
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Law @ 2017-06-30 15:11 UTC (permalink / raw)
To: Martin Liška, Richard Biener
Cc: David Malcolm, GCC Patches, Joseph Myers, Martin Sebor
On 06/30/2017 04:31 AM, Martin Liška wrote:
> On 04/10/2017 05:44 PM, Richard Biener wrote:
>> On Mon, Apr 10, 2017 at 5:42 PM, Jeff Law <law@redhat.com> wrote:
>>> On 04/07/2017 04:30 AM, Martin Liška wrote:
>>>>
>>>> On 04/06/2017 06:44 PM, Jeff Law wrote:
>>>>>
>>>>> On 03/24/2017 03:29 AM, Martin Liška wrote:
>>>>>>
>>>>>> I would like to ping that. I'm not sure what's agreement after I read
>>>>>> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
>>>>>>
>>>>>> Martin Sebor may know, CC'ing him.
>>>>>
>>>>> Not sure if you're pinging the internal_error_cont stuff, or the ODR
>>>>> diagnostics changes.
>>>>>
>>>>> WRT the ODR diagnostics, I'd say let's go with the C++17 style
>>>>> (all-lowercase with a hyphen).
>>>>>
>>>>> If you've got a pointer to the internal_err_cont changes, please pass it
>>>>> along.
>>>>
>>>>
>>>> Yep, I was interested in internal_err_cont. It's next stage1 material, but
>>>> I'm willing to have
>>>> a feedback whether separation of internal messages is desired to be
>>>> excluded from translation or not?
>>>
>>> As stage1 stuff, I'll largely be ignoring.
>>>
>>> I'm torn on translating this stuff. It's hard enough for a non-developer to
>>> interpret an ICE message, if it's not in their native language it'd be
>>> impossible.
>>>
>>> OTOH, if we translate and the user forwards the translated message to us, we
>>> may not be able to interpret.
>>>
>>> That probably argues there's some part that should be translated to be
>>> easier for the users, but the real guts of the message should not be
>>> translated.
>>
>> Message number and catalogue.
>>
>> /me runs...
>>
>>> jeff
>
> I there any discussion going on this topic? If not, I'll probably leave it as it is.
No ongoing discussion -- I'm working through my backlog of items that
were deferred for gcc-8 stage1 as well as items that I couldn't get to
while focused on stack-clash.
jeff
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-06-30 15:11 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 13:54 [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files Martin Liška
2017-03-15 18:33 ` David Malcolm
2017-03-20 13:10 ` Martin Liška
2017-03-24 9:39 ` Martin Liška
2017-03-24 16:22 ` Martin Sebor
2017-03-24 17:51 ` Jeff Law
2017-04-06 16:44 ` Jeff Law
2017-04-06 20:58 ` [wwwdocs, PATCH v2] C++ terminology: the One Definition Rule in diagnostics David Malcolm
2017-04-10 7:38 ` Gerald Pfeifer
2017-04-07 10:30 ` [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files Martin Liška
2017-04-10 15:42 ` Jeff Law
2017-04-10 15:44 ` Richard Biener
2017-06-30 10:31 ` Martin Liška
2017-06-30 15:11 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).