From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 1319C386F82B for ; Thu, 26 May 2022 06:17:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1319C386F82B Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q5liNK018386; Thu, 26 May 2022 06:17:45 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ga3qcggqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 06:17:44 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24Q6F1vI025826; Thu, 26 May 2022 06:17:44 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ga3qcggpx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 06:17:44 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24Q6CfxH029118; Thu, 26 May 2022 06:12:41 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 3g93ux248g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 06:12:41 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24Q6CdoT19399098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 May 2022 06:12:39 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 191444C04A; Thu, 26 May 2022 06:12:39 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5BC904C046; Thu, 26 May 2022 06:12:37 +0000 (GMT) Received: from [9.197.252.204] (unknown [9.197.252.204]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 May 2022 06:12:36 +0000 (GMT) Message-ID: <338badbf-d784-76fb-95f2-58f6aa7ffae7@linux.ibm.com> Date: Thu, 26 May 2022 14:12:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH, rs6000] Clean up the option_mask defines (part 1) Content-Language: en-US To: will schmidt Cc: GCC Patches , Segher Boessenkool , David Edelsohn References: <6591013b62270c39c912f0c13c4cd12ffbaf75a2.camel@vnet.ibm.com> From: "Kewen.Lin" In-Reply-To: <6591013b62270c39c912f0c13c4cd12ffbaf75a2.camel@vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: q-OrpewwJrmVoHLgC8oq3JsdJBobZHjO X-Proofpoint-ORIG-GUID: MdAJKc22gN9CsfFYwaOYuQerBzQz9DMe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_02,2022-05-25_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 mlxlogscore=762 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205260030 X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 06:17:49 -0000 Hi Will, on 2022/5/26 04:25, will schmidt via Gcc-patches wrote: > [PATCH, rs6000] Clean up the option_mask defines > > Hi, > > We have an assortment of MASK and OPTION_MASK #defines throughout > the rs6000 code, MASK_ALTIVEC and OPTION_MASK_ALTIVEC as an example. > > We currently #define the MASK_ entries to their OPTION_MASK_ > equivalents so the two names could be used interchangeably. > > The mapping is in place from when we switched from using > target_flags to rs6000_isa_flags via > commit 4d9675496a28ef6184f2a9c3ac5e6e3ea63606c1 in 2012. > > This patch converts the references for most of the lingering MASK_* > values to OPTION_MASK_* and removes the now redundant defines. > Nice, thanks for the cleanup! > I have split this into multiple parts due to size. > I guess they can be bootstrapped & regressed incrementally? I found there are still some masks left: MASK_POWERPC64, MASK_64BIT and MASK_LITTLE_ENDIAN. Is there one part 4 for them? Or is there some particular reason not to clean up them? BR, Kewen