From: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
To: richard.sandiford <richard.sandiford@arm.com>
Cc: rguenther <rguenther@suse.de>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Re: [PATCH] VECT: Support CALL vectorization for COND_LEN_*
Date: Tue, 25 Jul 2023 19:31:26 +0800 [thread overview]
Message-ID: <33D742B74BE060CC+2023072519312540614935@rivai.ai> (raw)
In-Reply-To: <mptmszkfg1f.fsf@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
Hi, Richard.
>> I think we should have an internal-fn helper that returns IFN_COND_LEN_*
>> for a given IFN_COND_*. It could handle IFN_MASK_LOAD -> IFN_MASK_LEN_LOAD
>> etc. too.
Could you name this helper function for me? Does it call "get_conditional_len_internal_fn_for_conditional_fn" ?
Thanks.
juzhe.zhong@rivai.ai
From: Richard Sandiford
Date: 2023-07-25 18:21
To: juzhe.zhong\@rivai.ai
CC: rguenther; gcc-patches
Subject: Re: [PATCH] VECT: Support CALL vectorization for COND_LEN_*
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai> writes:
> Thanks Richard.
>
> Do you suggest we should add a macro like this first:
>
> #ifndef DEF_INTERNAL_COND_FN
> #define DEF_INTERNAL_COND_FN(NAME, FLAGS, OPTAB, TYPE) \
> DEF_INTERNAL_OPTAB_FN (COND_##NAME, FLAGS, cond_##optab, cond_##TYPE)
> DEF_INTERNAL_OPTAB_FN (COND_LEN_##NAME, FLAGS, cond_len_##optab, cond_len_##TYPE)
> #endif
Yeah. (Think there's a missing backslash though.)
> If yes, maybe I should first do this in a single patch first?
Yeah, doing it as a separate patch sounds good.
Richard
next prev parent reply other threads:[~2023-07-25 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 11:46 juzhe.zhong
2023-07-24 14:33 ` Richard Biener
2023-07-24 23:16 ` 钟居哲
2023-07-25 9:41 ` Richard Sandiford
2023-07-25 10:17 ` juzhe.zhong
2023-07-25 10:21 ` Richard Sandiford
2023-07-25 11:31 ` juzhe.zhong [this message]
2023-07-25 12:18 ` Richard Sandiford
2023-07-31 9:30 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33D742B74BE060CC+2023072519312540614935@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).