Hi, Richard. >> I think we should have an internal-fn helper that returns IFN_COND_LEN_* >> for a given IFN_COND_*. It could handle IFN_MASK_LOAD -> IFN_MASK_LEN_LOAD >> etc. too. Could you name this helper function for me? Does it call "get_conditional_len_internal_fn_for_conditional_fn" ? Thanks. juzhe.zhong@rivai.ai From: Richard Sandiford Date: 2023-07-25 18:21 To: juzhe.zhong\@rivai.ai CC: rguenther; gcc-patches Subject: Re: [PATCH] VECT: Support CALL vectorization for COND_LEN_* "juzhe.zhong@rivai.ai" writes: > Thanks Richard. > > Do you suggest we should add a macro like this first: > > #ifndef DEF_INTERNAL_COND_FN > #define DEF_INTERNAL_COND_FN(NAME, FLAGS, OPTAB, TYPE) \ > DEF_INTERNAL_OPTAB_FN (COND_##NAME, FLAGS, cond_##optab, cond_##TYPE) > DEF_INTERNAL_OPTAB_FN (COND_LEN_##NAME, FLAGS, cond_len_##optab, cond_len_##TYPE) > #endif Yeah. (Think there's a missing backslash though.) > If yes, maybe I should first do this in a single patch first? Yeah, doing it as a separate patch sounds good. Richard