From: Nathan Sidwell <nathan@acm.org>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jason Merrill <jason@redhat.com>
Subject: Re: [C++ Patch] PR 85070 ("[8/9 Regression] ICE on C++ code: in lazily_declare_fn, at cp/method.c:2409")
Date: Mon, 24 Sep 2018 15:42:00 -0000 [thread overview]
Message-ID: <33c001bb-6b85-41c6-eb68-7c98d19d311d@acm.org> (raw)
In-Reply-To: <5bbe72a0-c9c7-4d62-c5b2-74fe5d9098f9@oracle.com>
On 9/24/18 3:48 AM, Paolo Carlini wrote:
> Hi,
>
> as explained in the audit trail, the gcc_assert added by Nathan triggers
> during error-recovery too, when add_method correctly returns false
> because it failed to add the method. Thus it seems that we should simply
> loosen a bit the assertion. Tested x86_64-linux.
ok
--
Nathan Sidwell
next prev parent reply other threads:[~2018-09-24 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 10:58 Paolo Carlini
2018-09-24 15:42 ` Nathan Sidwell [this message]
2018-10-11 18:18 ` Jakub Jelinek
2018-10-11 18:32 ` Paolo Carlini
2018-10-11 18:37 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c001bb-6b85-41c6-eb68-7c98d19d311d@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).