From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118805 invoked by alias); 24 Sep 2018 15:20:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118791 invoked by uid 89); 24 Sep 2018 15:20:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:mail-pg, H*r:sk:mail-pg, HX-Received:a62, H*RU:sk:mail-pg X-HELO: mail-pg1-f180.google.com Received: from mail-pg1-f180.google.com (HELO mail-pg1-f180.google.com) (209.85.215.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 15:20:53 +0000 Received: by mail-pg1-f180.google.com with SMTP id z3-v6so4325672pgv.8 for ; Mon, 24 Sep 2018 08:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=29e02qZHLG5x9/gUR93M21+JwgCgy/UJuYBi6sv5KdA=; b=ek8Cpf/ApbgNWsQWskIB57OjUvX81QzIUfvtmakU7UKJ25lQ3IehPiEcJpclIYXmO/ fmbeK57lG6OK7uqTd+ofhxtdELULR/c3fpvtyGOzUJAV/IVb4HGhukpeyLqrElT8mLsm 2SUX/XFyt1Rnv/4tgr7BckB4kQnpO5BRHGWGw9XcNmLBwNXK9FORb/wtAZ0vlQwi+KDY hwGJmoiq0i/PLOSCuCJArc9BZdkuRrtCBJekJqylKINw+5TkrRoTwj14WZHcoihVcJei 3ztUYZs0wyKKD7FPDaDqrrfQ6e/v/BgvnJVgD87wcIJaAqkqSYTo5wWSopgw+nfjqAx1 gfpQ== Return-Path: Received: from [10.50.15.234] ([67.135.43.183]) by smtp.googlemail.com with ESMTPSA id y4-v6sm49811852pfn.123.2018.09.24.08.20.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 08:20:49 -0700 (PDT) Sender: Nathan Sidwell Subject: Re: [C++ Patch] PR 85070 ("[8/9 Regression] ICE on C++ code: in lazily_declare_fn, at cp/method.c:2409") To: Paolo Carlini , "gcc-patches@gcc.gnu.org" Cc: Jason Merrill References: <5bbe72a0-c9c7-4d62-c5b2-74fe5d9098f9@oracle.com> From: Nathan Sidwell Message-ID: <33c001bb-6b85-41c6-eb68-7c98d19d311d@acm.org> Date: Mon, 24 Sep 2018 15:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <5bbe72a0-c9c7-4d62-c5b2-74fe5d9098f9@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg01350.txt.bz2 On 9/24/18 3:48 AM, Paolo Carlini wrote: > Hi, > > as explained in the audit trail, the gcc_assert added by Nathan triggers > during error-recovery too, when add_method correctly returns false > because it failed to add the method. Thus it seems that we should simply > loosen a bit the assertion. Tested x86_64-linux. ok -- Nathan Sidwell