From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9E8473858433 for ; Mon, 5 Feb 2024 15:15:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E8473858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E8473858433 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707146108; cv=none; b=rKyp1k4cCotX8aiCBJxOsEkOrproo0GRHKF77fXqHkzu0n0Hn/EzOl0y2HgN1cjuQQi2/JomaWzSDRPyka9T3tDPMV4R/8wlLkpZCZKMrWiAYRTKsYaeVYQ3e/eEZgadb7rhj2YDR5UQywQxZh3VFX3/YdUZtNh8NUijpJxKW9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707146108; c=relaxed/simple; bh=ihGcPisNqClHeLG/Yav+LgET/0yX/IDtI6WsGlXfio8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LQHZd5n1Bf4afNPPqtUyvuia31WdUx62x6xYhkU9C9z+R4Kjaeh5OuUEwIzHXiejhxrupdkimtXMog1ISwbGVB0aQS2yL7qIAkTNRD9EZBm3WufRM0yN5ud75Czor3UXx8GPybTh0wDNR2rAsoDiMKyJypKVJSa+iUXoRyaj0Uo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707146105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O1C2B9HMVb7KBSqwMV5+SxHm/nYbbm9UctdlUus6H/E=; b=ajZbADfMmQtfrUYlSeZ6St0cZtP2SjLb/fOuktI8t9eo1v14mmS7QhhFKsF9njE7baoTYb wv/ELhug55MbmCyfttd3Bzwjjeh90iAFusCIlMRvCIQ1Ltp9qFygLvAEfgkN2qsfnxccM9 EcHPqjepmWpKoJJAyF7iSxkU5Oa64zA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-VTQ_qdLHPSiQy5HpyEDCew-1; Mon, 05 Feb 2024 10:15:03 -0500 X-MC-Unique: VTQ_qdLHPSiQy5HpyEDCew-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-68c92bf4129so22665706d6.2 for ; Mon, 05 Feb 2024 07:15:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707146102; x=1707750902; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O1C2B9HMVb7KBSqwMV5+SxHm/nYbbm9UctdlUus6H/E=; b=VWODLEjFvbEezF0p9HwfbZJhpi0R8M8B+Q93l7m0TMiMzqSoi6Cq28ZI81s/OUlLAV Z8OQ/C8PbsZ2Y6qMKooaHrIbQj+WOPxlzqgxhSy13kqNQH+na5NlyiaGiZIosSJen0+I RJ5cN4Z+ck19f1yrfTQEv1v88rG8aBVsZJYSWI4N5w5qgjMy/+odYy7LGhc+/BFtu33M JFfnOWkv0rbCIFiHmDs2vVC//+DUOZjTcvDDg7SXA47cGmxQly7KbwENVAuRJqRLEAUR caHU72x/hqGJWj7L2T2H1Rye+qgyN4F/JF3dx62eoJJaRQHJh0UbOOxUSySkbnQg4bI2 Djhg== X-Gm-Message-State: AOJu0YxtQ+XQgm9DnEzyQUegtSzctXXrTF7WTC8drKtM8eDGOVA55Fy4 +K08oO8oZ5g+POSmqzbtdh2iYFa0RbzJeyykCPzsjL5tyUGaF7f39Nyq1elZWAkaAAd/g5JW3fO prnDuhNrc524TymOdW0vTodkrioagQA0jFCVZwS0Aq/2tnFIfKUiP9TY= X-Received: by 2002:a0c:9799:0:b0:686:1e2:7480 with SMTP id l25-20020a0c9799000000b0068601e27480mr6489066qvd.37.1707146102517; Mon, 05 Feb 2024 07:15:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwzPZQ0NyWx6TZ05X3F+oM8cgBEy7DHc1lEeGHpeHK5M9pO1ogC+afKbhUQcWv6tfBImZ3Fg== X-Received: by 2002:a0c:9799:0:b0:686:1e2:7480 with SMTP id l25-20020a0c9799000000b0068601e27480mr6489039qvd.37.1707146102207; Mon, 05 Feb 2024 07:15:02 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWQlTyheIeyxqQh81Th8cMmzR+z336ky4k5AvEIUs+Sjf196IIou7FB+tqtEmd5xMrBa/rC6DcOi+tj4c0R6E6ib1hf6pmFCQ== Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id w15-20020a0cef8f000000b0068c89047955sm45215qvr.112.2024.02.05.07.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Feb 2024 07:15:01 -0800 (PST) Message-ID: <33d7ca3c-e361-4405-b8e0-efbad6b7c75a@redhat.com> Date: Mon, 5 Feb 2024 10:15:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libitm: small update for C++20 To: Marek Polacek , GCC Patches References: <20240203151459.1198772-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20240203151459.1198772-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/3/24 10:14, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. > -- >8 -- > C++20 DR 2237 disallows simple-template-id in cdtors, so you > can't write > > template > struct S { > S(); // should be S(); > }; > > This hasn't been a problem until now but I'm adding a warning about it > to -Wc++20-compat which libitm apparently uses. > > libitm/ChangeLog: > > * containers.h (vector): Remove the template-id in constructors. > --- > libitm/containers.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libitm/containers.h b/libitm/containers.h > index 2842fa038ed..4160b16d569 100644 > --- a/libitm/containers.h > +++ b/libitm/containers.h > @@ -48,7 +48,7 @@ class vector > static const size_t default_resize_min = 32; > > // Don't try to copy this vector. > - vector(const vector& x); > + vector(const vector& x); > > public: > typedef T datatype; > @@ -59,7 +59,7 @@ class vector > T& operator[] (size_t pos) { return entries[pos]; } > const T& operator[] (size_t pos) const { return entries[pos]; } > > - vector(size_t initial_size = default_initial_capacity) > + vector(size_t initial_size = default_initial_capacity) > : m_capacity(initial_size), > m_size(0) > { > @@ -68,7 +68,7 @@ class vector > else > entries = 0; > } > - ~vector() { if (m_capacity) free(entries); } > + ~vector() { if (m_capacity) free(entries); } > > void resize(size_t additional_capacity) > { > > base-commit: 78005c648921899a674d1e561b49b05ccabedfe0