Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[FX Coudert]

Heads-up: this broke bootstrap on darwin:

> +typedef void (^dispatch_mach_handler_t)(dispatch_mach_reason reason,
> +                                        dispatch_mach_msg_t message,
> +                                        mach_error_t error);


Blocks are an Apple/clang extension, not (yet) supported by GCC.

FX

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[FX Coudert]

I have reported the issue to llvm at https://github.com/llvm/llvm-project/issues/72639
There is a trivial one-line patch to fix it, which I hope they will accept. Not sure what our policy is here, in the meantime.

FX

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[Jakub Jelinek]

On Fri, Nov 17, 2023 at 12:31:40PM +0100, FX Coudert wrote:
> I have reported the issue to llvm at https://github.com/llvm/llvm-project/issues/72639
> There is a trivial one-line patch to fix it, which I hope they will accept. Not sure what our policy is here, in the meantime.

If they accept it say within a day, wait for it + cherry-pick to GCC,
otherwise apply to GCC as a local patch in anticipation they accept it.
If it is all that fixes Darwin support, great.

	Jakub

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[FX Coudert]

> If they accept it say within a day, wait for it + cherry-pick to GCC,
> otherwise apply to GCC as a local patch in anticipation they accept it.
> If it is all that fixes Darwin support, great.

With that patch, I can finish bootstrap, and regtesting is undergoing but I’m seeing no issue so far.

FX

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[Iain Sandoe]

Hi FX

> On 17 Nov 2023, at 11:57, FX Coudert <fxcoudert@gmail.com> wrote:
> 
>> If they accept it say within a day, wait for it + cherry-pick to GCC,
>> otherwise apply to GCC as a local patch in anticipation they accept it.
>> If it is all that fixes Darwin support, great.
> 
> With that patch, I can finish bootstrap, and regtesting is undergoing but I’m seeing no issue so far.

I see that the fix was applied locally (and my bootstraps on various Darwin versions worked OK),
but I’m not clear if you submitted a PR upstream (or just the bug report).  If the fix is to remain
local-only, it should be added to the list in LOCAL_PATCHES.

thanks for handling this,
Iain

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[FX]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]



> I see that the fix was applied locally (and my bootstraps on various Darwin versions worked OK),
> but I’m not clear if you submitted a PR upstream (or just the bug report).  If the fix is to remain
> local-only, it should be added to the list in LOCAL_PATCHES.

Patch was submitted upstream: https://github.com/llvm/llvm-project/pull/72642

FX

[PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[Jakub Jelinek]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi!

The following patch is result of libsanitizer/merge.sh
from c425db2eb558c263 (yesterday evening).

Bootstrapped/regtested on x86_64-linux and i686-linux (together with
the follow-up 3 patches I'm about to post).

Iain, could you please check Darwin?

And anyone else their favourite platform?

BTW, seems upstream has added riscv64 support for I think lsan/tsan,
so if anyone is willing to try it there, it would be a matter of
copying e.g. the s390*-*-linux* libsanitizer/configure.tgt entry
to riscv64-*-linux* with the obvious s/s390x/riscv64/ change in it.

Thanks.

	Jakub

[-- Attachment #2: gcc14-libsanitizer-merge.patch.gz --]
[-- Type: application/gzip, Size: 140278 bytes --]

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[Sam James]

Jakub Jelinek <jakub@redhat.com> writes:

> Hi!
>
> The following patch is result of libsanitizer/merge.sh
> from c425db2eb558c263 (yesterday evening).
>
> Bootstrapped/regtested on x86_64-linux and i686-linux (together with
> the follow-up 3 patches I'm about to post).
>
> Iain, could you please check Darwin?
>
> And anyone else their favourite platform?
>
> BTW, seems upstream has added riscv64 support for I think lsan/tsan,
> so if anyone is willing to try it there, it would be a matter of
> copying e.g. the s390*-*-linux* libsanitizer/configure.tgt entry
> to riscv64-*-linux* with the obvious s/s390x/riscv64/ change in it.

Thank you for doing it.

This will fix PR109882.

>
> Thanks.
>
> 	Jakub
>
> [2. application/gzip; gcc14-libsanitizer-merge.patch.gz]...

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

[Richard Biener]

On Wed, 15 Nov 2023, Jakub Jelinek wrote:

> Hi!
> 
> The following patch is result of libsanitizer/merge.sh
> from c425db2eb558c263 (yesterday evening).
> 
> Bootstrapped/regtested on x86_64-linux and i686-linux (together with
> the follow-up 3 patches I'm about to post).
> 
> Iain, could you please check Darwin?
> 
> And anyone else their favourite platform?
> 
> BTW, seems upstream has added riscv64 support for I think lsan/tsan,
> so if anyone is willing to try it there, it would be a matter of
> copying e.g. the s390*-*-linux* libsanitizer/configure.tgt entry
> to riscv64-*-linux* with the obvious s/s390x/riscv64/ change in it.

OK for the series.

> Thanks.
> 
> 	Jakub
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)