From: Joseph Myers <joseph@codesourcery.com>
To: Martin Uecker <uecker@tugraz.at>
Cc: <gcc-patches@gcc.gnu.org>, Richard Biener <rguenther@suse.de>
Subject: Re: [C PATCH v3] Fix ICEs related to VM types in C 2/2
Date: Mon, 22 May 2023 20:22:09 +0000 [thread overview]
Message-ID: <345f7f5-ebcb-4ab7-bdad-72cd5d5d3867@codesourcery.com> (raw)
In-Reply-To: <d4357b98b6e61dc227db9b21e21e5878af6a7ceb.camel@tugraz.at>
On Mon, 22 May 2023, Martin Uecker via Gcc-patches wrote:
> +static void
> +add_decl_expr(location_t loc, enum decl_context decl_context, tree type, tree *expr)
Missing space before '(', and the line should be wrapped to be no more
than 80 columns.
The C front-end changes are OK with those fixes. The testsuite changes
are also OK.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-05-22 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 17:23 Martin Uecker
2023-05-22 20:22 ` Joseph Myers [this message]
2023-05-23 6:13 ` Richard Biener
2023-05-23 6:24 ` Martin Uecker
2023-05-23 8:18 ` Richard Biener
2023-05-23 9:25 ` Martin Uecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345f7f5-ebcb-4ab7-bdad-72cd5d5d3867@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=uecker@tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).