From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12979 invoked by alias); 11 Feb 2020 15:22:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12276 invoked by uid 89); 11 Feb 2020 15:22:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_COUK,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: imap3.hz.codethink.co.uk Received: from imap3.hz.codethink.co.uk (HELO imap3.hz.codethink.co.uk) (176.9.8.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 15:22:09 +0000 Received: from [167.98.27.226] (helo=[10.35.5.172]) by imap3.hz.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1j1XMT-0003ES-Mf; Tue, 11 Feb 2020 15:22:05 +0000 Subject: Re: [9/10 Regression, PATCH] fortran: ICE in gfc_validate_kind(): Got bad kind [PR93580] To: sgk@troutmask.apl.washington.edu Cc: gcc-patches , fortran References: <802db473-0383-5fe1-2493-4968b133312b@codethink.co.uk> <20200211152031.GA77655@troutmask.apl.washington.edu> From: Mark Eggleston Message-ID: <347c3b09-c3fa-8568-f27c-88ee0a3c6c27@codethink.co.uk> Date: Tue, 11 Feb 2020 15:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200211152031.GA77655@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2020-02/txt/msg00653.txt.bz2 So it does, I'll have an other go. On 11/02/2020 15:20, Steve Kargl wrote: > On Tue, Feb 11, 2020 at 02:41:26PM +0000, Mark Eggleston wrote: >> Please find attached a patch, it is based on Steve Kargl's patch in PR93580 >> adding  a check for %len and test case. >> > Looks like the wrong diff was attached. > >> gcc/fortran/match.c | 4 ++-- >> gcc/testsuite/gfortran.dg/pr93484_1.f90 | 8 ++++++++ >> gcc/testsuite/gfortran.dg/pr93484_2.f90 | 8 ++++++++ >> 3 files changed, 18 insertions(+), 2 deletions(-) >> create mode 100644 gcc/testsuite/gfortran.dg/pr93484_1.f90 >> create mode 100644 gcc/testsuite/gfortran.dg/pr93484_2.f90 >> >> diff --git a/gcc/fortran/match.c b/gcc/fortran/match.c >> index a74cb8c5c19..03adfca9bd9 100644 >> --- a/gcc/fortran/match.c >> +++ b/gcc/fortran/match.c >> @@ -2222,9 +2222,9 @@ gfc_match_type_spec (gfc_typespec *ts) >> >> found: >> >> - m = gfc_match_init_expr (&e); >> + m = gfc_match_expr (&e); >> if (m == MATCH_NO || m == MATCH_ERROR) >> - return MATCH_NO; >> + return m; -- https://www.codethink.co.uk/privacy.html