From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <amacleod@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by sourceware.org (Postfix) with ESMTP id D399B386F022
 for <gcc-patches@gcc.gnu.org>; Tue, 12 Jan 2021 14:29:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D399B386F022
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-446-e6RRJZTaOrKDB2OsdB8ZQw-1; Tue, 12 Jan 2021 09:29:55 -0500
X-MC-Unique: e6RRJZTaOrKDB2OsdB8ZQw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79469C73AB;
 Tue, 12 Jan 2021 14:29:54 +0000 (UTC)
Received: from [10.10.118.121] (ovpn-118-121.rdu2.redhat.com [10.10.118.121])
 by smtp.corp.redhat.com (Postfix) with ESMTP id ACAFF5D9CD;
 Tue, 12 Jan 2021 14:29:53 +0000 (UTC)
Subject: Re: make FOR_EACH_IMM_USE_STMT safe for early exits
To: Alexandre Oliva <oliva@adacore.com>,
 Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
References: <orv9f7cm8v.fsf@livre.home> <oreelq7s2w.fsf@livre.home>
 <oro8kt2f88.fsf_-_@livre.home>
 <B7698CF0-A5A2-4AE1-9620-2EEA313243EA@gmail.com> <ora6w8xmi3.fsf@livre.home>
 <CAFiYyc2-E=ZBc1m1q7GrCsF+ui9TUc0+G30gz_+ACU9PQ4C1BQ@mail.gmail.com>
 <ormu07vy21.fsf@livre.home>
 <CAFiYyc04uYeUi4T33GL4Y6fR7_UM9js2BdMKmLFU49sm933jHw@mail.gmail.com>
 <orh7odfqhi.fsf_-_@lxoliva.fsfla.org>
 <CAFiYyc22_-KzKTWWjTXn8p+7ybNeJ_7pEsQnYpVR_g9YA93VfA@mail.gmail.com>
 <orpn2i2ta2.fsf@lxoliva.fsfla.org>
 <CAFiYyc2mWPozCivi+ibLoLHiaR_Dxf=8M=PzMQLeUL_xw_9sJw@mail.gmail.com>
 <orim85u9yl.fsf@lxoliva.fsfla.org>
From: Andrew MacLeod <amacleod@redhat.com>
Message-ID: <3491b8e0-7290-0d87-6ab6-98aa7a945950@redhat.com>
Date: Tue, 12 Jan 2021 09:29:52 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <orim85u9yl.fsf@lxoliva.fsfla.org>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A,
 RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2021 14:29:58 -0000

On 1/9/21 3:33 PM, Alexandre Oliva wrote:
> On Jan  7, 2021, Richard Biener <richard.guenther@gmail.com> wrote:
>
>> On Wed, Jan 6, 2021 at 12:34 PM Alexandre Oliva <oliva@adacore.com> wrote:
>>> On Jan  4, 2021, Richard Biener <richard.guenther@gmail.com> wrote:
>>>
>>>> Thus, please remove uses of BREAK_FROM_IMM_USE_STMT
>>>> together with this patch.
>>> And RETURN_FROM_IMM_USE_STMT, I suppose?
>> Sure.
> Done.
>
>
> make FOR_EACH_IMM_USE_STMT safe for early exits
>
> Use a dtor to automatically remove ITER from IMM_USE list in
> FOR_EACH_IMM_USE_STMT.
>
> Regstrapped on x86_64-linux-gnu.  Ok to install?
>
>
>
Nice!  I like it.  One less wart for my epitaph :-).

Thanks
Andrew