From: Stefan Liebler <stli@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] S/390: Fix PR91628
Date: Wed, 1 Apr 2020 08:28:16 +0200 [thread overview]
Message-ID: <349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com> (raw)
In-Reply-To: <0afe1b58-2544-98c2-b056-a724f1a5fa6d@linux.ibm.com>
ping
On 3/23/20 6:04 PM, Stefan Liebler wrote:
> Hi,
>
> this patch picks up Robin Dapps patch __tls_get_offset-in-separate.S.
> See "Bugzilla 91628 - libdruntime uses glibc internal symbol on s390"
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628)
>
> The original purpose was to get rid of the usage of the glibc-internal
> symbol __tls_get_addr_internal.
>
> The patch has not applied as is, therefore I've just regenerated the
> configure and Makefiles.
>
> Furthermore if build with multilib, the file
> gcc/libphobos/libdruntime/config/systemz/get_tls_offset.S is used
> for both configurations: systemz and s390.
> Therefore both implementations are now in the systemz file which
> uses an "#ifdef __s390x__" in order to distinguish both cases.
> The s390 file is just including the systemz one.
>
> Bye,
> Stefan
>
> --
>
> libphobos/ChangeLog:
>
> 2019-11-27 Robin Dapp <rdapp@linux.ibm.com>
> 2020-03-23 Stefan Liebler <stli@linux.ibm.com>
>
> * configure: Regenerate.
> * libdruntime/Makefile.am: Add s390x and s390.
> * libdruntime/Makefile.in: Regenerate.
> * libdruntime/config/s390/get_tls_offset.S: New file.
> * libdruntime/config/systemz/get_tls_offset.S: New file.
> * libdruntime/gcc/sections/elf_shared.d: Use ibmz_get_tls_offset.
> * m4/druntime/cpu.m4: Add s390x and s390.
next prev parent reply other threads:[~2020-04-01 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 17:04 Stefan Liebler
2020-04-01 6:28 ` Stefan Liebler [this message]
2020-04-01 10:50 ` Iain Buclaw
2020-04-01 16:20 ` Stefan Liebler
2020-04-07 14:33 ` Stefan Liebler
2020-04-07 16:26 ` Iain Buclaw
2020-04-07 19:09 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).