From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 91493385BF83 for ; Wed, 1 Apr 2020 06:28:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 91493385BF83 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 031631t6064001 for ; Wed, 1 Apr 2020 02:28:22 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 304edwhv4k-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 01 Apr 2020 02:28:21 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Apr 2020 07:28:06 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 1 Apr 2020 07:28:04 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0316SGTd35520682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 1 Apr 2020 06:28:16 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82FCEAE045; Wed, 1 Apr 2020 06:28:16 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5754AAE04D; Wed, 1 Apr 2020 06:28:16 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.145.41.185]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 1 Apr 2020 06:28:16 +0000 (GMT) Subject: Re: [PATCH] S/390: Fix PR91628 From: Stefan Liebler To: GCC Patches References: <0afe1b58-2544-98c2-b056-a724f1a5fa6d@linux.ibm.com> Date: Wed, 1 Apr 2020 08:28:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <0afe1b58-2544-98c2-b056-a724f1a5fa6d@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20040106-0016-0000-0000-000002FC25B9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20040106-0017-0000-0000-0000335FE87E Message-Id: <349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-03-31_07:2020-03-31, 2020-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010049 X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 06:28:24 -0000 ping On 3/23/20 6:04 PM, Stefan Liebler wrote: > Hi, > > this patch picks up Robin Dapps patch __tls_get_offset-in-separate.S. > See "Bugzilla 91628 - libdruntime uses glibc internal symbol on s390" > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91628) > > The original purpose was to get rid of the usage of the glibc-internal > symbol __tls_get_addr_internal. > > The patch has not applied as is, therefore I've just regenerated the > configure and Makefiles. > > Furthermore if build with multilib, the file > gcc/libphobos/libdruntime/config/systemz/get_tls_offset.S is used > for both configurations: systemz and s390. > Therefore both implementations are now in the systemz file which > uses an "#ifdef __s390x__" in order to distinguish both cases. > The s390 file is just including the systemz one. > > Bye, > Stefan > > -- > > libphobos/ChangeLog: > > 2019-11-27  Robin Dapp  > 2020-03-23  Stefan Liebler  > >     * configure: Regenerate. >     * libdruntime/Makefile.am: Add s390x and s390. >     * libdruntime/Makefile.in: Regenerate. >     * libdruntime/config/s390/get_tls_offset.S: New file. >     * libdruntime/config/systemz/get_tls_offset.S: New file. >     * libdruntime/gcc/sections/elf_shared.d: Use ibmz_get_tls_offset. >     * m4/druntime/cpu.m4: Add s390x and s390.