From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 8C54C3858D28 for ; Mon, 8 Apr 2024 16:29:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C54C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C54C3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712593744; cv=none; b=WrPPdzQheBPq5spH5fR773kL8S+scdsG+His3JDzlDakN2Kn7kSQGoVEkO8f30/EjQcjcxguADRSlLWf04SdZ/C8utDaL4J8TXE6l+MtZ1KPidXXhtIiFnGMhAM2qCrxC76oqJyMhrruBe2NPck4VDoeopcmK6LUNpi5Ub+lQWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712593744; c=relaxed/simple; bh=g4lBd6BI4tUeZm7LIyIA1hmjGWR7WflegAjj3l+7HC8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: Mime-Version:Subject:Date:Message-Id:To; b=upIteqVTdAIIp1n7vFX2e3+F5sdHJmQE3c2m0Gl84XQVP4hATVZFohaPcYvg3BDdHFFSyEU7vplaTuFevZt3HDl1cFHlEk+FJp4KwpCCy12ghdmUeJZQPH3dsjLtJEhqngOXL9AQLjii++Fbg0TJ/Lnf6fUpO6B8wGfAnLsZhjc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 24B3322AC7; Mon, 8 Apr 2024 16:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712593741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8/JDvycYQUvZS9AdCRnQGKnxXCXPFwLKed9zfXQ7Fk=; b=BIL54d7oYzeAwV44hxVTjMvYVcCAx3VHfH5I3AALZO1CCoD6HTpchDL4yZbnC3S9cFkbm7 ttWe4/pRCFDXkz0WqDsjyvo5gkTTNsb66sUe4icOMpf948frp+ub7tJGHcJYwxFnZMBpw8 HSvzdGQEElkTWp3PCkY+k0iBXP5PD1c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712593741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8/JDvycYQUvZS9AdCRnQGKnxXCXPFwLKed9zfXQ7Fk=; b=ASICNrKVJ5GUrqaJl6WtfobbaEC7+ZJlmdL7Ww8lpdEloaajF5Ysk5ydlzygHPJDppJYxU KBgU14g1MloVZEDg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712593741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8/JDvycYQUvZS9AdCRnQGKnxXCXPFwLKed9zfXQ7Fk=; b=BIL54d7oYzeAwV44hxVTjMvYVcCAx3VHfH5I3AALZO1CCoD6HTpchDL4yZbnC3S9cFkbm7 ttWe4/pRCFDXkz0WqDsjyvo5gkTTNsb66sUe4icOMpf948frp+ub7tJGHcJYwxFnZMBpw8 HSvzdGQEElkTWp3PCkY+k0iBXP5PD1c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712593741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8/JDvycYQUvZS9AdCRnQGKnxXCXPFwLKed9zfXQ7Fk=; b=ASICNrKVJ5GUrqaJl6WtfobbaEC7+ZJlmdL7Ww8lpdEloaajF5Ysk5ydlzygHPJDppJYxU KBgU14g1MloVZEDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 16A0C1332F; Mon, 8 Apr 2024 16:29:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id GUuBBU0bFGZYDAAAn2gu4w (envelope-from ); Mon, 08 Apr 2024 16:29:01 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] middle-end/114604 - ranger allocates bitmap without initialized obstack Date: Mon, 8 Apr 2024 18:28:50 +0200 Message-Id: <34A40EEC-538B-4899-9683-F1B4285F7C4C@suse.de> References: Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org, amacleod@redhat.com In-Reply-To: To: Aldy Hernandez X-Mailer: iPhone Mail (21E236) X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; APPLE_IOS_MAILER_COMMON(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap2.dmz-prg2.suse.org:helo,imap2.dmz-prg2.suse.org:rdns,gimple-range.cc:url] X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 08.04.2024 um 18:09 schrieb Aldy Hernandez : >=20 > =EF=BB=BFOn Mon, Apr 8, 2024 at 5:54=E2=80=AFPM Jakub Jelinek wrote: >>=20 >> On Mon, Apr 08, 2024 at 05:40:23PM +0200, Aldy Hernandez wrote: >>>> PR middle-end/114604 >>>> * gimple-range.cc (enable_ranger): Initialize the global >>>> bitmap obstack. >>>> (disable_ranger): Release it. >>>> --- >>>> gcc/gimple-range.cc | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>>=20 >>>> diff --git a/gcc/gimple-range.cc b/gcc/gimple-range.cc >>>> index c16b776c1e3..4d3b1ce8588 100644 >>>> --- a/gcc/gimple-range.cc >>>> +++ b/gcc/gimple-range.cc >>>> @@ -689,6 +689,8 @@ enable_ranger (struct function *fun, bool use_imm_u= ses) >>>> { >>>> gimple_ranger *r; >>>>=20 >>>> + bitmap_obstack_initialize (NULL); >>>> + >>>> gcc_checking_assert (!fun->x_range_query); >>>> r =3D new gimple_ranger (use_imm_uses); >>>> fun->x_range_query =3D r; >>>> @@ -705,6 +707,8 @@ disable_ranger (struct function *fun) >>>> gcc_checking_assert (fun->x_range_query); >>>> delete fun->x_range_query; >>>> fun->x_range_query =3D NULL; >>>> + >>>> + bitmap_obstack_release (NULL); >>>=20 >>> Are you not allowed to initialize/use obstacks unless >>> bitmap_obstack_initialize(NULL) is called? >>=20 >> You can use it with some other obstack, just not the default one. >>=20 >>> If so, wouldn't it be >>> better to lazily initialize it downstream (bitmap_alloc, or whomever >>> needs it initialized)? >>=20 >> No, you still need to decide where is the safe point to release it. >> Unlike the non-default bitmap_obstack_initialize/bitmap_obstack_release, >> the default one can nest (has associated nesting counter). So, the above= >> patch just says that ranger starts using the default obstack in >> enable_ranger and stops using it in disable_ranger and anything ranger >> associated in the obstack can be freed at that point. >=20 > I thought ranger never used the default one: >=20 > $ grep bitmap_obstack_initialize *value* *range* > value-relation.cc: bitmap_obstack_initialize (&m_bitmaps); > value-relation.cc: bitmap_obstack_initialize (&m_bitmaps); > gimple-range-cache.cc: bitmap_obstack_initialize (&m_bitmaps); > gimple-range-gori.cc: bitmap_obstack_initialize (&m_bitmaps); > gimple-range-infer.cc: bitmap_obstack_initialize (&m_bitmaps); > gimple-range-phi.cc: bitmap_obstack_initialize (&m_bitmaps); >=20 > or even: >=20 > $ grep obstack.*NULL *value* *range* > value-range-storage.cc: obstack_free (&m_obstack, NULL); > value-relation.cc: obstack_free (&m_chain_obstack, NULL); > value-relation.cc: obstack_free (&m_chain_obstack, NULL); > gimple-range-infer.cc: obstack_free (&m_list_obstack, NULL); > value-range-storage.cc: obstack_free (&m_obstack, NULL); >=20 > I'm obviously missing something here. Look for BITMAP_ALLOC (NULL) in the backtrace in the PR Richard=20 > Aldy >=20