public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: Joseph S. Myers <joseph@codesourcery.com>
Cc: Marc Jones <marcj303@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Add HANDLE_PRAGMA_PACK_PUSH_POP to the i386-elf gcc target
Date: Fri, 19 Nov 2010 03:44:00 -0000	[thread overview]
Message-ID: <34E1451C-D8C1-4650-B9E8-4840DB107A82@comcast.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1011190110260.8391@digraph.polyomino.org.uk>

On Nov 18, 2010, at 5:15 PM, Joseph S. Myers wrote:
> I think we should just enable HANDLE_PRAGMA_PACK_PUSH_POP unconditionally.  
> That eliminates a target macro - one used in front ends, where we would 
> particularly like to eliminate them - and simplifies the testsuite (no 
> need for tests of this pragma to be conditional), as well as improving 
> portability of code between supported targets; I don't see any reason to 
> restrict this feature to some targets only.  This in turn obsoletes 
> HANDLE_SYSV_PRAGMA as well (the documentation claiming it also affects 
> #pragma weak is wrong), so two target macros can die.

I endorse this as well.

  reply	other threads:[~2010-11-19  2:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  2:04 Marc Jones
2010-11-19  2:40 ` Joseph S. Myers
2010-11-19  3:44   ` Mike Stump [this message]
2010-11-19  4:02     ` Dave Korn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34E1451C-D8C1-4650-B9E8-4840DB107A82@comcast.net \
    --to=mikestump@comcast.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=marcj303@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).