public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] LoongArch: NFC: Dedup and sort the comment in loongarch_print_operand_reloc
@ 2024-06-16  9:11 Xi Ruoyao
  2024-06-18  1:20 ` Lulu Cheng
  0 siblings, 1 reply; 2+ messages in thread
From: Xi Ruoyao @ 2024-06-16  9:11 UTC (permalink / raw)
  To: gcc-patches; +Cc: chenglulu, i, xuchenghua, Xi Ruoyao

gcc/ChangeLog:

	* config/loongarch/loongarch.cc (loongarch_print_operand_reloc):
	Dedup and sort the comment describing modifiers.
---

It's a non-functional change thus I've not tested it.  Ok for trunk?

 gcc/config/loongarch/loongarch.cc | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc
index 256b76d044b..dcb32a96577 100644
--- a/gcc/config/loongarch/loongarch.cc
+++ b/gcc/config/loongarch/loongarch.cc
@@ -6132,21 +6132,13 @@ loongarch_print_operand_reloc (FILE *file, rtx op, bool hi64_part,
    'T'	Print 'f' for (eq:CC ...), 't' for (ne:CC ...),
 	      'z' for (eq:?I ...), 'n' for (ne:?I ...).
    't'	Like 'T', but with the EQ/NE cases reversed
-   'F'	Print the FPU branch condition for comparison OP.
-   'W'	Print the inverse of the FPU branch condition for comparison OP.
-   'w'	Print a LSX register.
    'u'	Print a LASX register.
-   'T'	Print 'f' for (eq:CC ...), 't' for (ne:CC ...),
-	      'z' for (eq:?I ...), 'n' for (ne:?I ...).
-   't'	Like 'T', but with the EQ/NE cases reversed
-   'Y'	Print loongarch_fp_conditions[INTVAL (OP)]
-   'Z'	Print OP and a comma for 8CC, otherwise print nothing.
-   'z'	Print $0 if OP is zero, otherwise print OP normally.
    'v'	Print the insn size suffix b, h, w or d for vector modes V16QI, V8HI,
 	  V4SI, V2SI, and w, d for vector modes V4SF, V2DF respectively.
    'V'	Print exact log2 of CONST_INT OP element 0 of a replicated
 	  CONST_VECTOR in decimal.
    'W'	Print the inverse of the FPU branch condition for comparison OP.
+   'w'	Print a LSX register.
    'X'	Print CONST_INT OP in hexadecimal format.
    'x'	Print the low 16 bits of CONST_INT OP in hexadecimal format.
    'Y'	Print loongarch_fp_conditions[INTVAL (OP)]
-- 
2.45.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] LoongArch: NFC: Dedup and sort the comment in loongarch_print_operand_reloc
  2024-06-16  9:11 [PATCH] LoongArch: NFC: Dedup and sort the comment in loongarch_print_operand_reloc Xi Ruoyao
@ 2024-06-18  1:20 ` Lulu Cheng
  0 siblings, 0 replies; 2+ messages in thread
From: Lulu Cheng @ 2024-06-18  1:20 UTC (permalink / raw)
  To: Xi Ruoyao, gcc-patches; +Cc: i, xuchenghua

I think that's fine.

Thanks!

在 2024/6/16 下午5:11, Xi Ruoyao 写道:
> gcc/ChangeLog:
>
> 	* config/loongarch/loongarch.cc (loongarch_print_operand_reloc):
> 	Dedup and sort the comment describing modifiers.
> ---
>
> It's a non-functional change thus I've not tested it.  Ok for trunk?
>
>   gcc/config/loongarch/loongarch.cc | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc
> index 256b76d044b..dcb32a96577 100644
> --- a/gcc/config/loongarch/loongarch.cc
> +++ b/gcc/config/loongarch/loongarch.cc
> @@ -6132,21 +6132,13 @@ loongarch_print_operand_reloc (FILE *file, rtx op, bool hi64_part,
>      'T'	Print 'f' for (eq:CC ...), 't' for (ne:CC ...),
>   	      'z' for (eq:?I ...), 'n' for (ne:?I ...).
>      't'	Like 'T', but with the EQ/NE cases reversed
> -   'F'	Print the FPU branch condition for comparison OP.
> -   'W'	Print the inverse of the FPU branch condition for comparison OP.
> -   'w'	Print a LSX register.
>      'u'	Print a LASX register.
> -   'T'	Print 'f' for (eq:CC ...), 't' for (ne:CC ...),
> -	      'z' for (eq:?I ...), 'n' for (ne:?I ...).
> -   't'	Like 'T', but with the EQ/NE cases reversed
> -   'Y'	Print loongarch_fp_conditions[INTVAL (OP)]
> -   'Z'	Print OP and a comma for 8CC, otherwise print nothing.
> -   'z'	Print $0 if OP is zero, otherwise print OP normally.
>      'v'	Print the insn size suffix b, h, w or d for vector modes V16QI, V8HI,
>   	  V4SI, V2SI, and w, d for vector modes V4SF, V2DF respectively.
>      'V'	Print exact log2 of CONST_INT OP element 0 of a replicated
>   	  CONST_VECTOR in decimal.
>      'W'	Print the inverse of the FPU branch condition for comparison OP.
> +   'w'	Print a LSX register.
>      'X'	Print CONST_INT OP in hexadecimal format.
>      'x'	Print the low 16 bits of CONST_INT OP in hexadecimal format.
>      'Y'	Print loongarch_fp_conditions[INTVAL (OP)]


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-18  1:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-16  9:11 [PATCH] LoongArch: NFC: Dedup and sort the comment in loongarch_print_operand_reloc Xi Ruoyao
2024-06-18  1:20 ` Lulu Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).