public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: Eric Gallager <egall@gwmail.gwu.edu>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <pinskia@gmail.com>
Subject: Re: [PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag
Date: Thu, 1 Dec 2022 22:30:13 -0700	[thread overview]
Message-ID: <34b41010-ce2a-f28a-9b3f-15578c1ecc0b@codesourcery.com> (raw)
In-Reply-To: <CAMfHzOu3Gni4WpBod+pM4=vjGFkFfTNV_BUbq3H26yW8GHXpdg@mail.gmail.com>

On 12/1/22 20:29, Eric Gallager via Gcc-patches wrote:
> A pretty simple patch; borrowed from Andrew Pinski on bugzilla:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447
> Tested by doing `./configure --help` in the gcc subdirectory and
> noting that the "(or later)" made it into the output. OK for trunk?
> 
> gcc/ChangeLog:
> 
>      PR bootstrap/59447
>      * configure: Regenerate.
>      * configure.ac: Document --with-dwarf2 flag as also applying to
> later DWARF standards.
>      * doc/install.texi: Likewise.

Hmmm.  In this hunk

> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index 589c64965b2..1d7c73eb914 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -1914,7 +1914,7 @@ should not be built.
>  
>  @item --with-dwarf2
>  Specify that the compiler should
> -use DWARF 2 debugging information as the default.
> +use DWARF 2 (or later) debugging information as the default.
>  
>  @item --with-advance-toolchain=@var{at}
>  On 64-bit PowerPC Linux systems, configure the compiler to use the

I think it would be better to say

use DWARF format for debugging information as the default; the exact 
DWARF version that is the default is target-specific.

OK with that change.

-Sandra

  reply	other threads:[~2022-12-02  5:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  3:29 Eric Gallager
2022-12-02  5:30 ` Sandra Loosemore [this message]
2022-12-02  6:18   ` Eric Gallager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34b41010-ce2a-f28a-9b3f-15578c1ecc0b@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=egall@gwmail.gwu.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).