From: Jeff Law <jeffreyalaw@gmail.com>
To: Roger Sayle <roger@nextmovesoftware.com>,
'GCC Patches' <gcc-patches@gcc.gnu.org>
Cc: 'Marc Glisse' <marc.glisse@inria.fr>
Subject: Re: [PATCH take 2] Fold bswap32(x) != 0 to x != 0 (and related transforms)
Date: Mon, 26 Jul 2021 08:55:23 -0600 [thread overview]
Message-ID: <34c17bea-a09d-ef6e-f2da-93f535621c33@gmail.com> (raw)
In-Reply-To: <087b01d78070$7299bf10$57cd3d30$@nextmovesoftware.com>
On 7/24/2021 3:44 AM, Roger Sayle wrote:
> My apologies for the short delay. Thanks for explaining why these
> transforms
> don't usually require explicit tests for side-effects (but occasionally do).
> This does simplify things; please find attached the shorter revised patch.
>
> This patch has been retested on x86_64-pc-linux-gnu with a make bootstrap
> and make -k check with no new failures. Ok for mainline?
>
> 2010-07-24 Roger Sayle <roger@nextmovesoftware.com>
> Marc Glisse <marc.glisse@inria.fr>
>
> gcc/ChangeLog
> * match.pd (rotate): Simplify equality/inequality of rotations.
> (bswap): Simplify equality/inequality tests of byte swapping.
>
> gcc/testsuite/ChangeLog
> * gcc.dg/fold-eqrotate-1.c: New test case.
> * gcc.dg/fold-eqbswap-1.c: New test case.
OK. Thanks!
jeff
prev parent reply other threads:[~2021-07-26 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 9:44 Roger Sayle
2021-07-26 14:55 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c17bea-a09d-ef6e-f2da-93f535621c33@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).