From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 6EC4E385840D for ; Mon, 26 Jul 2021 14:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EC4E385840D Received: by mail-pl1-x636.google.com with SMTP id d1so4640148pll.1 for ; Mon, 26 Jul 2021 07:55:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=GkLJ5N2JM9T41dxEzogHwcTyixnx9v6/pNI/EisVjng=; b=tlgsM0NFJbeAGcTEB436OnDnLEuAqLqoSzGUhr8WATj+0fhxk4mbWBtE39xxjaQsoG b5QdoleO1YBfA5pvuJjbNJqfj3VGU/q9JLvKczwAoVZJeYpMCs3PCmIBpSNEoVH03CSM IKmDBC9YLgEWH5kkuaPW52ja5HTf2iiNvgH0bZYFaJcqwBXDLuxdgL6vGR8vv8Bx/S2u heXQdTto3DA2hN3QXaDy1wFtNO5WWkDIIINyC1A7iB39ODYQmKORNMCE5pc13rDIPIUk V7dChpGL5wZ94YlskRwrC6M1+zLs7NssAyISZ1xoHcSA6eMCqyKnOhlUIGeJxVbWvOkR u4hA== X-Gm-Message-State: AOAM533KhxK06XSbTerGFTQXc4cE1S1+YhLV0pd+n3ZJartzJ+UhRNhk D/855l+iNVN6inFL7RcgHTQ= X-Google-Smtp-Source: ABdhPJzU00JCMA1vjGaC7ni6+TBHA4OFpTjXJvSpGajvHUaWrn3bDCkQ2BhPkfGWSMsAM7N/ADdwgw== X-Received: by 2002:a17:90a:380b:: with SMTP id w11mr17287965pjb.12.1627311327354; Mon, 26 Jul 2021 07:55:27 -0700 (PDT) Received: from [192.168.1.17] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id h17sm217141pfh.192.2021.07.26.07.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 07:55:27 -0700 (PDT) Subject: Re: [PATCH take 2] Fold bswap32(x) != 0 to x != 0 (and related transforms) To: Roger Sayle , 'GCC Patches' Cc: 'Marc Glisse' References: <087b01d78070$7299bf10$57cd3d30$@nextmovesoftware.com> From: Jeff Law Message-ID: <34c17bea-a09d-ef6e-f2da-93f535621c33@gmail.com> Date: Mon, 26 Jul 2021 08:55:23 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <087b01d78070$7299bf10$57cd3d30$@nextmovesoftware.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 14:55:29 -0000 On 7/24/2021 3:44 AM, Roger Sayle wrote: > My apologies for the short delay. Thanks for explaining why these > transforms > don't usually require explicit tests for side-effects (but occasionally do). > This does simplify things; please find attached the shorter revised patch. > > This patch has been retested on x86_64-pc-linux-gnu with a make bootstrap > and make -k check with no new failures. Ok for mainline? > > 2010-07-24 Roger Sayle > Marc Glisse > > gcc/ChangeLog > * match.pd (rotate): Simplify equality/inequality of rotations. > (bswap): Simplify equality/inequality tests of byte swapping. > > gcc/testsuite/ChangeLog > * gcc.dg/fold-eqrotate-1.c: New test case. > * gcc.dg/fold-eqbswap-1.c: New test case. OK.  Thanks! jeff